Feat/ip #1245
Merged
Feat/ip #1245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 14740456404Details
💛 - Coveralls |
|
Please find the ci env pod logs here |
|
Please find the ci env pod logs here |
|
Please find the ci env pod logs here |
jawadqur
previously approved these changes
Apr 29, 2025
fence/auth.py
Outdated
| @wraps(function) | ||
| def decorated_function(*args, **kwargs): | ||
| ip_info = get_ip_information_string() | ||
| logger.info(ip_info) |
There was a problem hiding this comment.
might be a bit difficult to know which IP log corresponds to which API call? does that matter?
Edit: I see the log_ip decorator is never actually used, and you just call get_ip_information_string directly in functions you want to log. Did you write it so we can add it to other functions later? or should we remove it?
There was a problem hiding this comment.
Yeah I had it b/c there's a potential future where we need to add the log per endpoint and I wanted a consistent way to do that. I can remove it though b/c it's not needed right now
| @@ -115,7 +158,7 @@ def set_flask_session_values(user): | |||
| # idp info persisted to the database. We return early to avoid | |||
| # unnecessarily re-saving that user and idp info. | |||
| if user.identity_provider and user.identity_provider.name == provider: | |||
| set_flask_session_values(user) | |||
| set_flask_session_values_and_log_ip(user) | |||
There was a problem hiding this comment.
do we need to log the IP for failed authentication attempts too?
There was a problem hiding this comment.
Good question, I asssumed not. Per security's response in today's architecture meeting 29 APR 2025 we do not need to log IP for non-successful IdP authentication events
fence/blueprints/well_known.py
Outdated
| @@ -6,6 +6,7 @@ | |||
|
|
|||
| import flask | |||
|
|
|||
| from fence.auth import log_ip | |||
There was a problem hiding this comment.
do we need this import
There was a problem hiding this comment.
nope, from an old test. Removing
Please find the detailed integration test report here Login here Please find the ci env pod logs here |
Please find the detailed integration test report here Login here Please find the ci env pod logs here |
paulineribeyre
approved these changes
Apr 30, 2025
Please find the detailed integration test report here Login here Please find the ci env pod logs here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to JIRA ticket if there is one:
New Features
Breaking Changes
Bug Fixes
Improvements
Dependency updates
Deployment changes