feat: globe coverage view renders v2 datasets. - #14
Merged
Merged
Conversation
The page assumed a single dataset and flat hierarchy but this has been updated in the core repo so that a dataset can have multiple variants. Support the updated format, rendering the first dataset if this format is found.
adpeace
marked this pull request as ready for review
July 23, 2026 21:23
Contributor
|
Thanks Andy! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re https://geotessera.org/coverage/:
The page assumed a single dataset and flat hierarchy but this has been updated in the core repo so that a dataset can have multiple variants. Support the updated format, rendering the first dataset if this format is found.
This was tested locally with coverage I generated using the geotessera CLI. However, I don't have access to a v1 dataset, so it's possible the fallback code doesn't work as intended.
There's another PR for geotessera incoming to switch the palette for the coverage texture to the one expected by this page when there's only a single variant: however that also required changing the globe viewer that the CLI emits to produce a correct legend for both single- and multiple-variant datasets. Not sure if that's how you want to handle it, but I will share the PR for your consideration.
AI usage declaration: Written with the assistance of Claude. Reviewed, updated, and approved by me. I'm hardly a typescript expert, though...