Skip to content

Conversation

@elamdf
Copy link
Contributor

@elamdf elamdf commented Jan 31, 2025

hammer-mentor-plugins is a private (NDAed) repository and shouldn't be a prt of the default chipyard repo, since it will break scripts that fetch all submodules due to insufficient permissions.

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • RTL change
  • Software change (RISC-V software)
  • Build system change
  • Other

Contributor Checklist:

  • Did you set main as the base branch?
  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • Did you mark the PR with a changelog: label?
  • (If applicable) Did you update the conda .conda-lock.yml file if you updated the conda requirements file?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you add a test demonstrating the PR?
  • (If applicable) Did you mark the PR as Please Backport?

CI Help:
Add the following labels to modify the CI for a set of features.
Generally, a label added only affect subsequent changes to the PR (i.e. new commits, force pushing, closing/reopening).
See ci:* for full list of labels:

  • ci:fpga-deploy - Run FPGA-based E2E testing
  • ci:local-fpga-buildbitstream-deploy - Build local FPGA bitstreams for platforms that are released
  • ci:disable - Disable CI

@abejgonzalez
Copy link
Contributor

@Mergifyio copy main

@mergify
Copy link

mergify bot commented Jan 31, 2025

copy main

✅ Pull request copies have been created

Details
  • Copy to branch main not needed, change already in branch main

Copy link
Contributor

@abejgonzalez abejgonzalez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SFTM. Pending CI.

@elamdf elamdf merged commit 1c95be9 into ucb-bar:main Feb 1, 2025
64 of 67 checks passed
@elamdf elamdf deleted the remove_mentor_submodule branch February 1, 2025 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants