Skip to content

Minimal verif changeset for public main#44

Merged
elamdf merged 7 commits intomainfrom
verif-test-PR-clean
Apr 13, 2025
Merged

Minimal verif changeset for public main#44
elamdf merged 7 commits intomainfrom
verif-test-PR-clean

Conversation

@Fi50
Copy link
Member

@Fi50 Fi50 commented Apr 8, 2025

PR just to add the Makefile flags, can remove OFOConfigs.scala if preferred.

(I only added the label to see if it's enough to pass require release notes but guess not. V_v)

@Fi50 Fi50 requested a review from elamdf April 8, 2025 04:39
@Fi50 Fi50 added the enhancement New feature or request label Apr 8, 2025
@elamdf
Copy link
Collaborator

elamdf commented Apr 8, 2025

where is RUN_TYPE_FLAG going to be read? I hesitate on principle to rely on script-exported environment variables for things that change...

@Fi50
Copy link
Member Author

Fi50 commented Apr 8, 2025

It's read in the generator >_< which is terrible decision but I think when I was doing this I couldn't find a way to:

  • find any useful existing env environment
  • find a way to get the tool/flow/etc targets
  • get the directory being run from directly

I'm sure there's gotta be a way, I just didn't find it so this was the bandage fix to move on with, am super open to alternatives!

@elamdf
Copy link
Collaborator

elamdf commented Apr 8, 2025

related: ucb-eecs151tapeout/ofot-generator#3

@elamdf
Copy link
Collaborator

elamdf commented Apr 8, 2025

export SBT_OPTS ?= -Dsbt.ivy.home=$(base_dir)/.ivy2 -Dsbt.global.base=$(base_dir)/.sbt -Dsbt.boot.directory=$(base_dir)/.sbt/boot/ -Dsbt.color=always -Dsbt.supershell=false -Dsbt.server.forcestart=true
you might be able to append SBT_OPTS with -D so it's not persistent in your environment after running the make command. I asked in chipyard channel too, so maybe let's wait for jz to show us da wae <_<

@elamdf
Copy link
Collaborator

elamdf commented Apr 10, 2025

can an issue be made about creating sim vs syn CONFIGs as a better alternative to the env variable hacking? else LGTM

@Fi50
Copy link
Member Author

Fi50 commented Apr 13, 2025

Made issue: #45
Leaving it to you to merge when happy :D

@elamdf elamdf merged commit daee693 into main Apr 13, 2025
60 of 67 checks passed
@elamdf
Copy link
Collaborator

elamdf commented Apr 13, 2025

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants