Skip to content

Setup qol changes#52

Merged
Bzzztt merged 5 commits intomainfrom
setup-qol-changes
Oct 3, 2025
Merged

Setup qol changes#52
Bzzztt merged 5 commits intomainfrom
setup-qol-changes

Conversation

@jimfangx
Copy link
Member

@jimfangx jimfangx commented Oct 2, 2025

Addresses setup failing if 151 Verilog is not included -- Students are not required to include their 151 core in labs 1. This will allow setup to finish without their RTL, then corresponding instructions (ucb-eecs151tapeout/eecs151t-labs#4) in Lab 2 will tell then to enable + integrate the OFO generator into build system

Addresses ara failing during step 5 of build-setup; added - to common.mk to allow command to fail if ara.mk is not found. added backup (allowed to fail) to setup chipyard.mk instead if that is found in any generator

Related PRs / Issues: None

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • RTL change
  • Software change (RISC-V software)
  • Build system change
  • Other

Contributor Checklist:

  • Did you set main as the base branch?
  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • Did you mark the PR with a changelog: label?
  • (If applicable) Did you update the conda .conda-lock.yml file if you updated the conda requirements file?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you add a test demonstrating the PR?
  • (If applicable) Did you mark the PR as Please Backport?

CI Help:
Add the following labels to modify the CI for a set of features.
Generally, a label added only affect subsequent changes to the PR (i.e. new commits, force pushing, closing/reopening).
See ci:* for full list of labels:

  • ci:fpga-deploy - Run FPGA-based E2E testing
  • ci:local-fpga-buildbitstream-deploy - Build local FPGA bitstreams for platforms that are released
  • ci:disable - Disable CI

@jimfangx jimfangx requested a review from a team October 2, 2025 05:55
@jimfangx jimfangx self-assigned this Oct 2, 2025
@jimfangx jimfangx added bug Something isn't working enhancement New feature or request labels Oct 2, 2025
Copy link
Contributor

@lorenshung lorenshung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Bzzztt Bzzztt merged commit 1a63152 into main Oct 3, 2025
57 of 63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants