add yml key for drc decks, add hook to turn off false rules for Pegasus DRC #1
Merged
add yml key for drc decks, add hook to turn off false rules for Pegasus DRC #1
Conversation
elamdf
requested changes
Jun 16, 2025
hammer/technology/sky130/__init__.py
Outdated
| deck_name=f"{self.get_setting('vlsi.core.drc_tool').replace('hammer.drc.', '')}_drc", | ||
| path=path, | ||
| ) | ||
| for path in self.get_setting("technology.sky130.sky130_drc_decks") |
elamdf
reviewed
Jun 17, 2025
elamdf
reviewed
Jun 17, 2025
| deck_name="pegasus_drc", | ||
| path=os.path.join( | ||
| SKY130_CDS, "Sky130_DRC", "sky130_rev_0.0_2.2.drc.pvl" | ||
| tool_name=self.get_setting("vlsi.core.drc_tool").replace( |
elamdf
approved these changes
Jun 17, 2025
elamdf
left a comment
There was a problem hiding this comment.
LGTM- can you include a comment on the 'false rules' addition in the PR title / merge commit before merging?
Member
Author
updated in the original PR comment + edited title |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds 2 things:
sky130_drc_decks: ["", "", ...]in tech-sky130.yml (one string containing path to deck for each deck) - it'll be added to the specific tool'sdrc_deckslist automatically givenvlsi.core.drc_toolis set in the tools.ymlFALSEOFFis defined, the rules are turned offRelated PRs / Issues
Type of change:
Impact:
Contributor Checklist:
masteras the base branch?poetry.lockfile if you updated the requirements inpyproject.toml?e2e/if this feature depends on updated plugins?