Skip to content

add yml key for drc decks, add hook to turn off false rules for Pegasus DRC #1

Merged
jimfangx merged 2 commits intomasterfrom
jim-changes
Jun 18, 2025
Merged

add yml key for drc decks, add hook to turn off false rules for Pegasus DRC #1
jimfangx merged 2 commits intomasterfrom
jim-changes

Conversation

@jimfangx
Copy link
Member

@jimfangx jimfangx commented Jun 16, 2025

Adds 2 things:

  • Add ability for users to specify their DRC deck via sky130_drc_decks: ["", "", ...] in tech-sky130.yml (one string containing path to deck for each deck) - it'll be added to the specific tool's drc_decks list automatically given vlsi.core.drc_tool is set in the tools.yml
  • Add hook for pegasus decks to turn false rules off. -- If you are using the Cadence DRC Deck sky130_rev_0.0_2.3, Cadence included a .cfg to turn off false rules - this typically has to be loaded via the GUI but this hook inserts the flags into pegasusdrcctl and turns the false rules off.
    • if FALSEOFF is defined, the rules are turned off

Related PRs / Issues

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • Change to core Hammer
  • Change to a Hammer plugin
  • Other

Contributor Checklist:

  • Did you set master as the base branch?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you update the poetry.lock file if you updated the requirements in pyproject.toml?
  • (If applicable) Did you add a unit test demonstrating the PR?
  • (If applicable) Did you run this through the e2e integration tests?
  • (If applicable) Did you update the submodules in e2e/ if this feature depends on updated plugins?

@jimfangx jimfangx requested review from Fi50 and elamdf June 16, 2025 20:29
deck_name=f"{self.get_setting('vlsi.core.drc_tool').replace('hammer.drc.', '')}_drc",
path=path,
)
for path in self.get_setting("technology.sky130.sky130_drc_decks")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you set a default in defaults?

@jimfangx jimfangx requested a review from elamdf June 17, 2025 01:57
deck_name="pegasus_drc",
path=os.path.join(
SKY130_CDS, "Sky130_DRC", "sky130_rev_0.0_2.2.drc.pvl"
tool_name=self.get_setting("vlsi.core.drc_tool").replace(
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is probably fine

Copy link

@elamdf elamdf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM- can you include a comment on the 'false rules' addition in the PR title / merge commit before merging?

@jimfangx jimfangx changed the title add yml key for drc decks, add hook for pegasus false rules add yml key for drc decks, add hook to turn off false rules for Pegasus DRC Jun 17, 2025
@jimfangx
Copy link
Member Author

LGTM- can you include a comment on the 'false rules' addition in the PR title / merge commit before merging?

updated in the original PR comment + edited title

@jimfangx jimfangx merged commit 0b9f0af into master Jun 18, 2025
0 of 3 checks passed
@jimfangx jimfangx deleted the jim-changes branch August 21, 2025 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants