Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instance Filtering
In this PR I added 7 buttons that act as filters in the My Widgets page of Materia. The filters include filtering by if an instance is a Draft, Published, Limited Attempts, Is Open, Is Expired, Guest Access, and Is Embedded. This PR is nearly identical to my 1595/instance-filtering branch but without the unrelated commits.
While filtering instances based on score data is possible, it may require significant structural changes to optimize performance. Potential changes could include:
However, these enhancements would go beyond the scope of this pull request.
Changes
In addition to adding filters, I have also refactored some of the html and css for the existing page to be more maintainable such as getting rid of absolute positioning, random margins, and opted to use flex and grid layouts to achieve the same look and so it could work with my new front end components.
The main front-end component I added was
checkbox-button.jsxwhich is a nice toggle button built using a hidden checkbox and a parent div with it's own custom styles included with focus support and voice-over accessibility.