Skip to content

Conversation

@Ishfaq-code
Copy link

There were instances where the SensoryMisuse issue was finding text with no sensory words. Issue was much different where it was finding it but the error element pointed to by the xpath was different. Turns out our equal access scanner was not saving xpath with a main.

Fix:
Don't check for main or div[1] in html.js

@dmols dmols mentioned this pull request Oct 2, 2025
@dmols dmols self-requested a review October 3, 2025 13:55
Copy link
Contributor

@dmols dmols left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Co-tested this with Ishfaq and we saw it remove the cases where we'd have the form pop up saying there were no sensory words found. Good to go!

@dmols dmols self-assigned this Oct 3, 2025
Copy link
Contributor

@mbusch3 mbusch3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on my system. I definitely get more errors, too. Meaning we were previously throwing out several OTHER issues as well... Thank you for the fix!

@dmols dmols merged commit 4beabef into ucfopen:new-main-page-UX Oct 7, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants