Fixes score screen accessibility issues related to color contrast and unintuitive design #89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR closes #88. When a player got a question correct, it was hard to determine which card they chose and which was correct. The score screen is overreliant on color and should provide more visual cues. I now indicate the card the user picked and whether each card corresponds to the right or wrong answer beyond the use of just color.
How?
In ctl-scoreScreen.js, I added an attribute to the item object that indicates the direction of the correct card. Since all the correct cards are ordered on the left side, I know that if the user got the question right, the chosen card is on the left and if the question was wrong, the chosen card is on the right. Now in the HTML, I display the flag banner of the correct response by using the knowledge of which card was chosen. I also added text to indicate the correct and wrong cards beyond just color for color-blind users. Additionally, I added a check or X mark on the side of the question to easily tell which question was right or wrong. I also used the words "correct" and "incorrect" since those were the words used on the creator side as well.