[achievements] test user_achievements template view#1227
Open
bensim0305 wants to merge 6 commits intodevfrom
Open
[achievements] test user_achievements template view#1227bensim0305 wants to merge 6 commits intodevfrom
bensim0305 wants to merge 6 commits intodevfrom
Conversation
abargher
requested changes
May 25, 2025
Contributor
abargher
left a comment
abargher
left a comment
There was a problem hiding this comment.
More merge conflicts, similar to the previous PR with test changes. I expect those to help fix these conflicts.
added 2 commits
May 24, 2025 23:11
….com:uchicago-cs/chigame into achievements/test_user_achievements_template
Contributor
Author
|
Fixed merge conflicts! |
abargher
approved these changes
May 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To address issue #1202 , I wrote unit tests testing the url pattern "user_achievements" and the views function user_achievements. This also tested the user_achievements html template, ensuring that cases where there are achievements unlocked, in progress, or none at all were behaving properly.