Skip to content

fixed dynamically created properties #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
opitz wants to merge 3 commits into from
Closed

fixed dynamically created properties #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
76c186d
fixed dynamically created properties
opitz Jan 28, 2026
2c5f609
updated moodle-ci.yml
opitz Jan 28, 2026
57fc4b2
making $preferences public
opitz Jan 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions .github/workflows/moodle-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ jobs:

services:
postgres:
image: postgres:14
image: postgres:16
env:
POSTGRES_USER: 'postgres'
POSTGRES_HOST_AUTH_METHOD: 'trust'
Expand All @@ -31,23 +31,23 @@ jobs:
fail-fast: false
matrix:
include:
- php: '8.2'
- php: '8.3'
moodle-branch: 'main'
database: 'mariadb'
- php: '8.2'
- php: '8.3'
moodle-branch: 'main'
database: 'pgsql'
- php: '8.1'
moodle-branch: 'MOODLE_405_STABLE'
database: 'mariadb'
- php: '8.1'
moodle-branch: 'MOODLE_404_STABLE'
- php: '8.3'
moodle-branch: 'MOODLE_501_STABLE'
database: 'pgsql'
- php: '8.2'
moodle-branch: 'MOODLE_501_STABLE'
database: 'mariadb'
- php: '8.2'
moodle-branch: 'MOODLE_405_STABLE'
database: 'pgsql'
- php: '8.1'
moodle-branch: 'MOODLE_403_STABLE'
database: 'mariadb'
- php: '8.0'
moodle-branch: 'MOODLE_401_STABLE'
moodle-branch: 'MOODLE_405_STABLE'
database: 'mariadb'

steps:
Expand Down
8 changes: 8 additions & 0 deletions tests/freezecontext_test.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@

use block_lifecycle\task\freezecontext;
use context_course;
use core_customfield\field_controller;
use stdClass;

/**
* Unit tests for block_lifecycle's freezecontext class.
Expand All @@ -28,6 +30,12 @@
* @author Alex Yeung <k.yeung@ucl.ac.uk>
*/
final class freezecontext_test extends \advanced_testcase {
/** @var field_controller field1 */
private field_controller $field1;

/** @var stdClass course */
private stdClass $course;

protected function setUp(): void {
parent::setUp();
$this->resetAfterTest();
Expand Down
48 changes: 47 additions & 1 deletion tests/manager_test.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
use context_course;
use core_customfield\field_controller;
use moodle_exception;
use stdClass;

/**
* Unit tests for block_lifecycle's manager class.
Expand All @@ -31,12 +32,57 @@
*/
final class manager_test extends \advanced_testcase {

/** @var field_controller field1 */
private field_controller $field1;

/** @var field_controller field2 */
private field_controller $field2;

/** @var array years - Contains the year strings of past year, current year and future year */
private array $years;

/** @var stdClass course1 */
private stdClass $course1;

/** @var stdClass course1 */
private stdClass $course2;

/** @var stdClass course1 */
private stdClass $course3;

/** @var stdClass course1 */
private stdClass $course4;

/** @var stdClass course1 */
private stdClass $courseshouldbefrozen;

/** @var stdClass course1 */
private stdClass $coursewithoutacademicyear;

/** @var stdClass course1 */
private stdClass $coursewithfutureenddate;

/** @var stdClass course1 */
private stdClass $coursewithoutenddate;
Comment on lines +47 to +66
Copy link
Contributor

@aydevworks aydevworks Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doc blocks content not matching the properties names.


/** @var int teacherroleid */
private int $teacherroleid;

/** @var int studentroleid */
private int $studentroleid;

/** @var stdClass user1 */
private stdClass $user1;

/** @var stdClass user2 */
private stdClass $user2;

/** @var stdClass preferences */
public stdClass $preferences;

/** @var int preferencesrecordid */
public int $preferencesrecordid;

protected function setUp(): void {
global $DB;
parent::setUp();
Expand Down Expand Up @@ -93,7 +139,7 @@ protected function setUp(): void {
$this->user2 = $dg->create_user();

// Create block_lifecyce record for $this->courseshouldbefrozen.
$this->preferences = new \stdClass();
$this->preferences = new stdClass();
$this->preferences->courseid = $this->courseshouldbefrozen->id;
$this->preferences->freezeexcluded = 0;
$this->preferences->freezedate = strtotime(date('Y-m-d') . ' -1 day');
Expand Down
Loading