CTP-5723: Show a placeholder name when marker anonymity enabled

classes/models/feedback.php

@@ -189,20 +189,6 @@ class feedback extends table_base {
      */
     private $showgrade = true;
 
-    /**
-     * This function is used for student view, it determines if assessors' names should be displayed or should be hidden
-     * @return string assessor's name
-     */
-    public function display_assessor_name() {
-
-        // check if assessor's name in this CW is set to hidden.
-        if ($this->is_assessor_anonymity_enabled()) {
-            return '';
-        } else {
-            return $this->assessor()->name();
-        }
-    }
-
     /**
      * @return string
      */

renderers/object_renderer.php

@@ -88,14 +88,21 @@ public function render_feedback(feedback $feedback, $showtitle = true) {
         $timeequal = ($feedback->timecreated == $feedback->timemodified);
         $isautomaticagreement = ((!$issamplingenabled || $sampledfeedbackexists) && $assessoriszero && $timeequal);
 
-        if (!$isautomaticagreement && $feedback->assessorid != 0) {
-            $template->markername = $feedback->display_assessor_name();
+        if (!$isautomaticagreement && $assessor = $feedback->assessor()) {
             $template->date = $feedback->timemodified;
 
-            // Marker image.
-            if ($feedback->assessor) {
-                $userpicture = new user_picture($feedback->assessor()->get_raw_record());
-                $userpicture->size = 100;
+            if (!$feedback->is_assessor_anonymity_enabled()) {
+                $template->markername = $assessor->name();
+            } else if ($feedback->is_moderation()) {
+                $template->markername = get_string('moderator', 'mod_coursework');
+            } else if ($stage = $feedback->get_assessor_stage_no()) {
+                $template->markername = get_string('markerheading', 'mod_coursework', $stage);
+            }
+
+            if ($feedback->is_assessor_anonymity_enabled()) {
+                $template->markerimg = $this->output->image_url('u/f1')->out(false);
+            } else {
+                $userpicture = new user_picture($assessor->get_raw_record());
                 $template->markerimg = $userpicture->get_url($this->page)->out(false);
             }
         }

styles.css

@@ -268,6 +268,11 @@ Coursework.
 }
 
 .path-mod-coursework {
+    .bg-cover {
+        background-size: cover;
+        background-position: center;
+    }
+
     /* Hide activity header - date and description displayed differently. */
     .activity-header {
         display: none !important;

tests/behat/feedback_single_marking.feature

@@ -52,3 +52,15 @@ Feature: Adding and editing single feedback
     And I visit the coursework page
     Then I should not see "Admin User" in the ".coursework-feedback" "css_element"
     But I should see "teacher teacher2" in the ".coursework-feedback" "css_element"
+
+  Scenario: Student cannot see marker when assessor anonymity is enabled
+    Given the submission is finalised
+    And there is finalised feedback for the submission from the teacher
+    And grades have been released
+    And I log out
+    When the coursework "assessoranonymity" setting is "1" in the database
+    And I log in as a student
+    And I visit the coursework page
+    Then I should not see "Admin User" in the ".coursework-feedback" "css_element"
+    And I should not see "teacher teacher2" in the ".coursework-feedback" "css_element"
+    But I should see "Marker 1" in the ".coursework-feedback" "css_element"