-
Notifications
You must be signed in to change notification settings - Fork 0
Upgrade dependencies #117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade dependencies #117
Conversation
4ec5b72 to
dd2a10b
Compare
dd2a10b to
10d1603
Compare
|
@RahulKhanna14 Please leave a review when you get the chance; do we have Netlify previews enabled? |
|
hey @mizlan , yeah you can access netlify previews in the checks section, at checks > pages changed > view index.html website looks good to me: still able to run, was able to use node v22 and didn't need to handle weird babel jest stuff. insane job lol, was there anything else you wanted to add before merging in? also out of curiosity what does the "const x = BigBRother.124.3;" line in setupFiles.js do, if anything? seems like it should be "BigBrother" if anything but even then not sure what it does |
RahulKhanna14
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, just wondering what the const x = BigBRother line does in setupFiles.js lol
|
oops |
fix: Refactor Navbar routing for React Router v7
We would link to /college/facebook, e.g., when we want to link to /facebook, which is a result of omitting a preceding "/" in a link
no, thats all for now i think |
RahulKhanna14
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great
Fixes #114