Skip to content

Conversation

@mizlan
Copy link
Member

@mizlan mizlan commented Apr 20, 2025

Fixes #114

@mizlan mizlan changed the title Mlan/upgrade deps Upgrade dependencies Apr 20, 2025
@mizlan mizlan force-pushed the mlan/upgrade-deps branch 2 times, most recently from 4ec5b72 to dd2a10b Compare April 22, 2025 05:49
@mizlan mizlan requested a review from RahulKhanna14 April 22, 2025 19:24
@mizlan mizlan force-pushed the mlan/upgrade-deps branch from dd2a10b to 10d1603 Compare April 30, 2025 02:50
@mizlan
Copy link
Member Author

mizlan commented May 1, 2025

@RahulKhanna14 Please leave a review when you get the chance; do we have Netlify previews enabled?

@RahulKhanna14
Copy link
Collaborator

hey @mizlan , yeah you can access netlify previews in the checks section, at checks > pages changed > view index.html

website looks good to me: still able to run, was able to use node v22 and didn't need to handle weird babel jest stuff. insane job lol, was there anything else you wanted to add before merging in?

also out of curiosity what does the "const x = BigBRother.124.3;" line in setupFiles.js do, if anything? seems like it should be "BigBrother" if anything but even then not sure what it does

Copy link
Collaborator

@RahulKhanna14 RahulKhanna14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just wondering what the const x = BigBRother line does in setupFiles.js lol

@mizlan
Copy link
Member Author

mizlan commented May 6, 2025

oops

mizlan added 6 commits May 6, 2025 17:05
fix: Refactor Navbar routing for React Router v7
We would link to /college/facebook, e.g., when we
want to link to /facebook, which is a result of
omitting a preceding "/" in a link
@mizlan mizlan force-pushed the mlan/upgrade-deps branch from 35752f7 to dbe79ca Compare May 7, 2025 00:06
@mizlan
Copy link
Member Author

mizlan commented May 7, 2025

was there anything else you wanted to add before merging in?

no, thats all for now i think

@RahulKhanna14 RahulKhanna14 self-requested a review May 7, 2025 00:36
Copy link
Collaborator

@RahulKhanna14 RahulKhanna14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great

@RahulKhanna14 RahulKhanna14 merged commit 3745329 into master May 7, 2025
4 checks passed
@RahulKhanna14 RahulKhanna14 deleted the mlan/upgrade-deps branch May 7, 2025 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Environment set-up issues

3 participants