Skip to content

Conversation

@Ethjin8
Copy link
Contributor

@Ethjin8 Ethjin8 commented Oct 31, 2025

Overview

Resolves #864

Deploy Preview: https://uclaacmwebsite.netlify.app/

Changes

  • Rerouted invite link of the main ACM Discord server to uclaacm.com/discord
  • Changed icon link to /discord in SocialMedia.js file
  • Added redirect() function in next.config.js file, pointing to the server invite
  • No new dependencies required

Testing

  • Hover over the Discord icons on the website page to see if new link is there
image

Possible Changes

  • The Discord invite links for other ACM committees haven't been rerouted and are still there, which warrants future fixing

Checklist

  • Code follows the project's style guidelines.
  • Documentation has been updated where necessary.
  • All checks pass and deploy builds with no errors.

@netlify
Copy link

netlify bot commented Oct 31, 2025

‼️ Deploy request for jovial-pasteur-581b4a rejected.

Name Link
🔨 Latest commit e0e6817

@Ethjin8 Ethjin8 requested review from NajmKHoda and smalex-z and removed request for NajmKHoda and smalex-z October 31, 2025 06:58
@smalex-z
Copy link
Contributor

Hey Ethan! Thanks for the PR; a few things though

  • First, can you recreate this PR as a branch within this repo? There's a few reasons for this;
    • Currently your branch is a branch within a forked repo, which makes it harder for others to push changes or tests locally
    • Because it is a fork of the repo, the Github Secrets (aka .env file) will not be exposed for security reasons (for example, if a random malicious actor forked the repo and wrote a script to dump secrets). This means the Github actions will always fail (see the 2 failing checks)
  • When you recreate the PR as a branch within this repo, the Netlify Github actions will run; you will see the deploy preview properly run then.

Thanks for being so on top of it! Let me know if you run into any issues :)

@Ethjin8
Copy link
Contributor Author

Ethjin8 commented Oct 31, 2025

Hey Alex,

Thanks for the help! I think I misunderstood the commit guidelines when doing this yesterday and didn't know why the tests were failing, so I asked Najm (didn't want to mess anything else up lol). I'll recreate the PR as a branch within the repo and close this one!

@Ethjin8 Ethjin8 closed this Oct 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reroute Discord Link

2 participants