Skip to content

Conversation

@Ethjin8
Copy link
Contributor

@Ethjin8 Ethjin8 commented Nov 12, 2025

Overview

Resolves #815

Deploy Preview: https://deploy-preview-874--jovial-pasteur-581b4a.netlify.app/

Changes

  • Changed image carousel layout so that every image fits together neatly (no white background behind them)
  • Added pop-out animation when cursor hovers over images
  • Created popup feature when images are clicked, opening a separate modal to view the full image

Testing

  • Scroll down to image carousel near the bottom of the website
  • Hover over images to view pop-out animation, click to open them in the image modal
image

Possible Changes

  • Some of the image popups are larger than others, could rework size to ensure consistency

Checklist

  • Code follows the project's style guidelines.
  • Documentation has been updated where necessary.
  • All checks pass and deploy builds with no errors.

Copy link
Contributor

@smalex-z smalex-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Ethan,

Great PR! Changes are great and look a lot better than before. A few changes from me and Nathan though off the visual aspect-

  • Ideally we shouldn't have a white background. If you can, try to do a "cover" css property instead, where we crop out any excess. We can assume a ratio of 4:5 or 3:5, whatever looks better to you
  • As for sizing, the image carousel appears a little big - Nathan and I think an ideal would probably be about 50%-75% of the current size.
  • Finally, instead of clicking on an image and having popping out into a new tab, it would probably look better if we opened it into a modal.

Great PR and thanks for the work!

@Ethjin8 Ethjin8 requested a review from smalex-z November 20, 2025 06:14
Copy link
Contributor

@smalex-z smalex-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ts tough good job

@Ethjin8 Ethjin8 merged commit 07933a7 into main Nov 22, 2025
8 checks passed
@Ethjin8 Ethjin8 deleted the fix-image-carousel branch November 22, 2025 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Image Carousal

3 participants