Leiqi concrete simulator #260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lichye
force-pushed
the
leiqi-concreteSimulator
branch
2 times, most recently
from
a816b70 to
d8c1f73
Compare
add autotester fix up bugs
add setup sbt
lichye
force-pushed
the
leiqi-concreteSimulator
branch
from
95353a9 to
6cd8952
Compare
polgreen
requested changes
Feb 27, 2025
Contributor
polgreen
left a comment
polgreen
left a comment
There was a problem hiding this comment.
Looks good. I have some questions about the comments that have been left in, and specifically what is a ConcreteUndef, and when do we encounter this.
Also, please add tests for
- all configuration options of the simulator
- testing violated assertions
- testing assumptions
- printing the trace
Contributor
|
ok this looks overall good. Might want to redo the bit that requires you to use a command line argument as well as a command in the control block but i see why you've done it, so will merge like this for now |
polgreen
approved these changes
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request will merge the concrete engine into the master respority.
The code does not change the main work flow of the Uclid5.
When "-c" is called, we will run concrete Simulator to simulate the uclid file.
There is still lots of util to be supported , but a early version will be helpful for testing.