Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new BasketRoom prefab/asset set (meshes + materials) intended to represent a basketball room with placed props.
Changes:
- Added many new mesh
.asset+.metafiles underBasketRoom/meshes. - Updated multiple materials to a different shader and updated texture/keyword settings.
- Modified prefab
.metafiles/guids and removed the included license text.
Reviewed changes
Copilot reviewed 99 out of 387 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| Assets/Prefabs/BasketPrefabs/BasketRoom/meshes/Cube.016_33_1.asset.meta | Adds Unity meta for new mesh asset |
| Assets/Prefabs/BasketPrefabs/BasketRoom/meshes/Cube.016_33_1.asset | Updates mesh name / vertex data blob |
| Assets/Prefabs/BasketPrefabs/BasketRoom/meshes/Cube.016_33_0.asset.meta | Adds Unity meta for new mesh asset |
| Assets/Prefabs/BasketPrefabs/BasketRoom/meshes/Cube.016_33_0.asset | Updates mesh name / vertex data blob |
| Assets/Prefabs/BasketPrefabs/BasketRoom/meshes/Cube.014_17_3.asset.meta | Adds Unity meta for new mesh asset |
| Assets/Prefabs/BasketPrefabs/BasketRoom/meshes/Cube.014_17_2.asset.meta | Adds Unity meta for new mesh asset |
| Assets/Prefabs/BasketPrefabs/BasketRoom/meshes/Cube.014_17_1.asset.meta | Adds Unity meta for new mesh asset |
| Assets/Prefabs/BasketPrefabs/BasketRoom/meshes/Cube.014_17_1.asset | Updates mesh name |
| Assets/Prefabs/BasketPrefabs/BasketRoom/meshes/Cube.014_17_0.asset.meta | Adds Unity meta for new mesh asset |
| Assets/Prefabs/BasketPrefabs/BasketRoom/meshes/Cube.013_16_3.asset.meta | Adds Unity meta for new mesh asset |
| Assets/Prefabs/BasketPrefabs/BasketRoom/meshes/Cube.013_16_2.asset.meta | Adds Unity meta for new mesh asset |
| Assets/Prefabs/BasketPrefabs/BasketRoom/meshes/Cube.013_16_2.asset | Updates mesh name |
| Assets/Prefabs/BasketPrefabs/BasketRoom/meshes/Cube.013_16_1.asset.meta | Adds Unity meta for new mesh asset |
| Assets/Prefabs/BasketPrefabs/BasketRoom/meshes/Cube.013_16_1.asset | Updates mesh name |
| Assets/Prefabs/BasketPrefabs/BasketRoom/meshes/Cube.013_16_0.asset.meta | Adds Unity meta for new mesh asset |
| Assets/Prefabs/BasketPrefabs/BasketRoom/meshes/Cube.012_15_3.asset.meta | Adds Unity meta for new mesh asset |
| Assets/Prefabs/BasketPrefabs/BasketRoom/meshes/Cube.012_15_3.asset | Updates mesh name / vertex data blob |
| Assets/Prefabs/BasketPrefabs/BasketRoom/meshes/Cube.012_15_2.asset.meta | Adds Unity meta for new mesh asset |
| Assets/Prefabs/BasketPrefabs/BasketRoom/meshes/Cube.012_15_2.asset | Updates mesh name |
| Assets/Prefabs/BasketPrefabs/BasketRoom/meshes/Cube.012_15_1.asset.meta | Adds Unity meta for new mesh asset |
| Assets/Prefabs/BasketPrefabs/BasketRoom/meshes/Cube.012_15_1.asset | Updates mesh name |
| Assets/Prefabs/BasketPrefabs/BasketRoom/meshes/Cube.012_15_0.asset.meta | Adds Unity meta for new mesh asset |
| Assets/Prefabs/BasketPrefabs/BasketRoom/meshes/Cube.010_5_0.asset.meta | Adds Unity meta for new mesh asset |
| Assets/Prefabs/BasketPrefabs/BasketRoom/meshes/Cube.010_5_0.asset | Updates mesh name |
| Assets/Prefabs/BasketPrefabs/BasketRoom/meshes/Cube.009_14_3.asset.meta | Adds Unity meta for new mesh asset |
| Assets/Prefabs/BasketPrefabs/BasketRoom/meshes/Cube.009_14_2.asset.meta | Adds Unity meta for new mesh asset |
| Assets/Prefabs/BasketPrefabs/BasketRoom/meshes/Cube.009_14_2.asset | Updates mesh name |
| Assets/Prefabs/BasketPrefabs/BasketRoom/meshes/Cube.009_14_1.asset.meta | Adds Unity meta for new mesh asset |
| Assets/Prefabs/BasketPrefabs/BasketRoom/meshes/Cube.009_14_1.asset | Updates mesh name |
| Assets/Prefabs/BasketPrefabs/BasketRoom/meshes/Cube.009_14_0.asset.meta | Adds Unity meta for new mesh asset |
| Assets/Prefabs/BasketPrefabs/BasketRoom/meshes/Cube.007_13_1.asset.meta | Adds Unity meta for new mesh asset |
| Assets/Prefabs/BasketPrefabs/BasketRoom/meshes/Cube.007_13_1.asset | Updates mesh name |
| Assets/Prefabs/BasketPrefabs/BasketRoom/meshes/Cube.007_13_0.asset.meta | Adds Unity meta for new mesh asset |
| Assets/Prefabs/BasketPrefabs/BasketRoom/meshes/Cube.006_2_0.asset.meta | Adds Unity meta for new mesh asset |
| Assets/Prefabs/BasketPrefabs/BasketRoom/meshes/Cube.006_2_0.asset | Updates mesh name |
| Assets/Prefabs/BasketPrefabs/BasketRoom/meshes/Cube.005_10_3.asset.meta | Adds Unity meta for new mesh asset |
| Assets/Prefabs/BasketPrefabs/BasketRoom/meshes/Cube.005_10_2.asset.meta | Adds Unity meta for new mesh asset |
| Assets/Prefabs/BasketPrefabs/BasketRoom/meshes/Cube.005_10_1.asset.meta | Adds Unity meta for new mesh asset |
| Assets/Prefabs/BasketPrefabs/BasketRoom/meshes/Cube.005_10_1.asset | Updates mesh name |
| Assets/Prefabs/BasketPrefabs/BasketRoom/meshes/Cube.005_10_0.asset.meta | Adds Unity meta for new mesh asset |
| Assets/Prefabs/BasketPrefabs/BasketRoom/meshes/Cube.005_10_0.asset | Adds new mesh asset |
| Assets/Prefabs/BasketPrefabs/BasketRoom/meshes/Cube.004_37_2.asset.meta | Adds Unity meta for new mesh asset |
| Assets/Prefabs/BasketPrefabs/BasketRoom/meshes/Cube.004_37_2.asset | Updates mesh name |
| Assets/Prefabs/BasketPrefabs/BasketRoom/meshes/Cube.004_37_1.asset.meta | Adds Unity meta for new mesh asset |
| Assets/Prefabs/BasketPrefabs/BasketRoom/meshes/Cube.004_37_1.asset | Updates mesh name |
| Assets/Prefabs/BasketPrefabs/BasketRoom/meshes/Cube.004_37_0.asset.meta | Adds Unity meta for new mesh asset |
| Assets/Prefabs/BasketPrefabs/BasketRoom/meshes/Cube.003_30_2.asset.meta | Adds Unity meta for new mesh asset |
| Assets/Prefabs/BasketPrefabs/BasketRoom/meshes/Cube.003_30_2.asset | Updates mesh name |
| Assets/Prefabs/BasketPrefabs/BasketRoom/meshes/Cube.003_30_1.asset.meta | Adds Unity meta for new mesh asset |
| Assets/Prefabs/BasketPrefabs/BasketRoom/meshes/Cube.003_30_0.asset.meta | Adds Unity meta for new mesh asset |
| Assets/Prefabs/BasketPrefabs/BasketRoom/meshes/Cube.002_4_0.asset.meta | Adds Unity meta for new mesh asset |
| Assets/Prefabs/BasketPrefabs/BasketRoom/meshes/Cube.001_3_0.asset.meta | Adds Unity meta for new mesh asset |
| Assets/Prefabs/BasketPrefabs/BasketRoom/meshes/Cube.001_3_0.asset | Updates mesh channels + vertex data blob |
| Assets/Prefabs/BasketPrefabs/BasketRoom/meshes/Circle_38_1.asset.meta | Adds Unity meta for new mesh asset |
| Assets/Prefabs/BasketPrefabs/BasketRoom/meshes/Circle_38_1.asset | Updates mesh name |
| Assets/Prefabs/BasketPrefabs/BasketRoom/meshes/Circle_38_0.asset.meta | Adds Unity meta for new mesh asset |
| Assets/Prefabs/BasketPrefabs/BasketRoom/meshes/Circle.003_26_2.asset.meta | Adds Unity meta for new mesh asset |
| Assets/Prefabs/BasketPrefabs/BasketRoom/meshes/Circle.003_26_2.asset | Adds new mesh asset |
| Assets/Prefabs/BasketPrefabs/BasketRoom/meshes/Circle.003_26_1.asset.meta | Adds Unity meta for new mesh asset |
| Assets/Prefabs/BasketPrefabs/BasketRoom/meshes/Circle.003_26_0.asset.meta | Adds Unity meta for new mesh asset |
| Assets/Prefabs/BasketPrefabs/BasketRoom/meshes/Circle.002_39_2.asset.meta | Adds Unity meta for new mesh asset |
| Assets/Prefabs/BasketPrefabs/BasketRoom/meshes/Circle.002_39_2.asset | Updates mesh name |
| Assets/Prefabs/BasketPrefabs/BasketRoom/meshes/Circle.002_39_1.asset.meta | Adds Unity meta for new mesh asset |
| Assets/Prefabs/BasketPrefabs/BasketRoom/meshes/Circle.002_39_1.asset | Updates mesh name |
| Assets/Prefabs/BasketPrefabs/BasketRoom/meshes/Circle.002_39_0.asset.meta | Updates mesh meta guid |
| Assets/Prefabs/BasketPrefabs/BasketRoom/meshes/Circle.001_25_2.asset.meta | Updates mesh meta guid |
| Assets/Prefabs/BasketPrefabs/BasketRoom/meshes/Circle.001_25_2.asset | Adds new mesh asset |
| Assets/Prefabs/BasketPrefabs/BasketRoom/meshes/Circle.001_25_1.asset.meta | Updates mesh meta guid |
| Assets/Prefabs/BasketPrefabs/BasketRoom/meshes/Circle.001_25_0.asset.meta | Updates mesh meta guid |
| Assets/Prefabs/BasketPrefabs/BasketRoom/materials/diagonal_parquet_3.mat | Updates shader + texture maps/keywords |
| Assets/Prefabs/BasketPrefabs/BasketRoom/materials/brick_wall_005_1.mat | Updates shader + texture maps/keywords |
| Assets/Prefabs/BasketPrefabs/BasketRoom/materials/White_Matt_0.mat | Updates shader configuration |
| Assets/Prefabs/BasketPrefabs/BasketRoom/materials/Profile_Light_Bright_10.mat | Updates shader + base color/smoothness |
| Assets/Prefabs/BasketPrefabs/BasketRoom/materials/Profile_Light_6.mat | Updates shader + base color/smoothness |
| Assets/Prefabs/BasketPrefabs/BasketRoom/materials/Mirror_2.mat | Updates shader + smoothness |
| Assets/Prefabs/BasketPrefabs/BasketRoom/materials/Light_Semi_Bright_12.mat | Updates shader + base color/smoothness |
| Assets/Prefabs/BasketPrefabs/BasketRoom/materials/Light_Dim_7.mat | Updates shader + base color/smoothness |
| Assets/Prefabs/BasketPrefabs/BasketRoom/materials/Light_Bright_13.mat | Updates shader + base color/smoothness |
| Assets/Prefabs/BasketPrefabs/BasketRoom/materials/Glass_9.mat | Converts material to transparent settings |
| Assets/Prefabs/BasketPrefabs/BasketRoom/materials/Cushion_11.mat | Updates shader + base color |
| Assets/Prefabs/BasketPrefabs/BasketRoom/materials/Black_Matt_8.mat | Updates shader + base color |
| Assets/Prefabs/BasketPrefabs/BasketRoom/materials/Black_Dark_5.mat | Updates shader + base color |
| Assets/Prefabs/BasketPrefabs/BasketRoom/materials/Ascent_Color_4.mat | Updates shader + keyword/lightmap flags |
| Assets/Prefabs/BasketPrefabs/BasketRoom/license.txt.meta | Removes license meta |
| Assets/Prefabs/BasketPrefabs/BasketRoom/license.txt | Removes license text |
| Assets/Prefabs/BasketPrefabs/BasketRoom/Imported.prefab.meta | Changes prefab meta guid/importer |
| Assets/Prefabs/BasketPrefabs/BasketRoom/BasketRoom.prefab.meta | Changes prefab meta guid |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Assets/Prefabs/BasketPrefabs/BasketRoom/meshes/Circle.002_39_0.asset.meta
Show resolved
Hide resolved
Assets/Prefabs/BasketPrefabs/BasketRoom/meshes/Circle.001_25_2.asset.meta
Show resolved
Hide resolved
Assets/Prefabs/BasketPrefabs/BasketRoom/meshes/Circle.001_25_1.asset.meta
Show resolved
Hide resolved
Assets/Prefabs/BasketPrefabs/BasketRoom/meshes/Circle.001_25_0.asset.meta
Show resolved
Hide resolved
| m_ModifiedSerializedProperties: 0 | ||
| m_ValidKeywords: | ||
| - _EMISSION | ||
| m_ValidKeywords: [] |
There was a problem hiding this comment.
This material no longer lists _EMISSION in m_ValidKeywords, but the material still has a non-black _EmissionColor (later in the file). In Unity/URP, emission typically won’t render unless the emission keyword is enabled. Consider re-enabling the _EMISSION keyword (or adjusting the shader/material settings so emission is actually active).
Suggested change
| m_ValidKeywords: [] | |
| m_ValidKeywords: | |
| - _EMISSION |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.