Open
Conversation
There was a problem hiding this comment.
Pull request overview
Adds handgun shooting support to the Unity project by importing weapon/bullet/hand assets and including a demo shooting script & related content.
Changes:
- Imported “Modern Guns: Handgun” and “Weapons Pack - Bullets” asset content (prefabs, materials, textures, meshes, demo assets).
- Added a
SimpleShootMonoBehaviour and supporting prefabs/materials to enable firing, muzzle flash, casing ejection. - Added gunshot audio and adjusted a volume profile setting.
Reviewed changes
Copilot reviewed 160 out of 542 changed files in this pull request and generated 20 comments.
Show a summary per file
| File | Description |
|---|---|
| Assets/Nokobot/Modern Guns - Handgun/_Prefabs/45ACP Bullet_Casing.prefab.meta | Adds meta for handgun casing prefab asset. |
| Assets/Nokobot/Modern Guns - Handgun/_Prefabs/45ACP Bullet.prefab.meta | Adds meta for handgun bullet prefab asset. |
| Assets/Nokobot/Modern Guns - Handgun/_Prefabs.meta | Adds folder meta for handgun prefabs. |
| Assets/Nokobot/Modern Guns - Handgun/_Demo Assets/SimpleShoot.cs.meta | Adds meta for demo shooting script. |
| Assets/Nokobot/Modern Guns - Handgun/_Demo Assets/SimpleShoot.cs | Adds demo script for firing/muzzle flash/casing ejection. |
| Assets/Nokobot/Modern Guns - Handgun/_Demo Assets/Post Process Volume.asset.meta | Adds meta for demo post-process volume. |
| Assets/Nokobot/Modern Guns - Handgun/_Demo Assets.meta | Adds folder meta for demo assets. |
| Assets/Nokobot/Modern Guns - Handgun/URP/Post Process Volume _URP.asset.meta | Adds meta for URP post-process volume asset. |
| Assets/Nokobot/Modern Guns - Handgun/URP/ModernGuns_Handgun_v1.2_URP.unitypackage.meta | Adds meta for URP unitypackage. |
| Assets/Nokobot/Modern Guns - Handgun/URP/Materials _URP/M1911 Magazine_Steel _URP.mat.meta | Adds meta for URP magazine steel material. |
| Assets/Nokobot/Modern Guns - Handgun/URP/Materials _URP/M1911 Magazine_Black _URP.mat.meta | Adds meta for URP magazine black material. |
| Assets/Nokobot/Modern Guns - Handgun/URP/Materials _URP/M1911 Handgun_Steel _URP.mat.meta | Adds meta for URP handgun steel material. |
| Assets/Nokobot/Modern Guns - Handgun/URP/Materials _URP/M1911 Handgun_Black _URP.mat.meta | Adds meta for URP handgun black material. |
| Assets/Nokobot/Modern Guns - Handgun/URP/Materials _URP/45ACP_Bullet_Silver _URP.mat.meta | Adds meta for URP bullet material. |
| Assets/Nokobot/Modern Guns - Handgun/URP/Materials _URP.meta | Adds folder meta for URP materials. |
| Assets/Nokobot/Modern Guns - Handgun/URP/Asset Collection _URP.unity.meta | Adds meta for URP asset collection scene. |
| Assets/Nokobot/Modern Guns - Handgun/URP.meta | Adds folder meta for URP content. |
| Assets/Nokobot/Modern Guns - Handgun/Textures/M1911_Magazine_Normal.png.meta | Adds meta for magazine normal texture import settings. |
| Assets/Nokobot/Modern Guns - Handgun/Textures/M1911_Magazine_MetallicSmoothness.png.meta | Adds meta for magazine metallic/smoothness texture. |
| Assets/Nokobot/Modern Guns - Handgun/Textures/M1911_Magazine_Albedo_Steel.png.meta | Adds meta for magazine albedo (steel). |
| Assets/Nokobot/Modern Guns - Handgun/Textures/M1911_Magazine_Albedo_Black.png.meta | Adds meta for magazine albedo (black). |
| Assets/Nokobot/Modern Guns - Handgun/Textures/M1911_Handgun_Normal.png.meta | Adds meta for handgun normal texture. |
| Assets/Nokobot/Modern Guns - Handgun/Textures/M1911_Handgun_MetallicSmoothness.png.meta | Adds meta for handgun metallic/smoothness texture. |
| Assets/Nokobot/Modern Guns - Handgun/Textures/M1911_Handgun_Albedo_Steel.png.meta | Adds meta for handgun albedo (steel). |
| Assets/Nokobot/Modern Guns - Handgun/Textures/M1911_Handgun_Albedo_Black.png.meta | Adds meta for handgun albedo (black). |
| Assets/Nokobot/Modern Guns - Handgun/Textures/45ACP_Bullet_Normal.png.meta | Adds meta for bullet normal texture. |
| Assets/Nokobot/Modern Guns - Handgun/Textures/45ACP_Bullet_Albedo_Silver.png.meta | Adds meta for bullet albedo texture. |
| Assets/Nokobot/Modern Guns - Handgun/Textures.meta | Adds folder meta for handgun textures. |
| Assets/Nokobot/Modern Guns - Handgun/README.txt.meta | Adds meta for handgun README. |
| Assets/Nokobot/Modern Guns - Handgun/README.txt | Adds vendor README content for imported handgun package. |
| Assets/Nokobot/Modern Guns - Handgun/Meshes/M1911 Magazine.fbx.meta | Adds meta for magazine mesh import settings. |
| Assets/Nokobot/Modern Guns - Handgun/Meshes/M1911 Handgun.fbx.meta | Adds meta for handgun mesh import settings. |
| Assets/Nokobot/Modern Guns - Handgun/Meshes/45ACP Bullet.fbx.meta | Adds meta for bullet mesh import settings. |
| Assets/Nokobot/Modern Guns - Handgun/Meshes.meta | Adds folder meta for handgun meshes. |
| Assets/Nokobot/Modern Guns - Handgun/Materials/M1911_Handgun_Normal.mat.meta | Adds meta for handgun normal material. |
| Assets/Nokobot/Modern Guns - Handgun/Materials/M1911_Handgun_Albedo_Steel.mat.meta | Updates material meta (GUID change). |
| Assets/Nokobot/Modern Guns - Handgun/Materials/M1911_Handgun_Albedo_Black.mat.meta | Updates material meta (GUID change). |
| Assets/Nokobot/Modern Guns - Handgun/Materials/M1911 Magazine_Steel.mat.meta | Adds meta for magazine steel material. |
| Assets/Nokobot/Modern Guns - Handgun/Materials/M1911 Magazine_Black.mat.meta | Adds meta for magazine black material. |
| Assets/Nokobot/Modern Guns - Handgun/Materials/M1911 Handgun_Steel.mat.meta | Adds meta for handgun steel material. |
| Assets/Nokobot/Modern Guns - Handgun/Materials/M1911 Handgun_Black.mat.meta | Adds meta for handgun black material. |
| Assets/Nokobot/Modern Guns - Handgun/Materials/45ACP_Bullet_Silver.mat.meta | Adds meta for bullet silver material. |
| Assets/Nokobot/Modern Guns - Handgun/Materials/45ACP_Bullet_Silver.mat | Updates bullet material settings/URP serialization. |
| Assets/Nokobot/Modern Guns - Handgun/Materials.meta | Adds folder meta for handgun materials. |
| Assets/Nokobot/Modern Guns - Handgun/Effects/MuzzleFlash_SpriteSheet.png.meta | Adds meta for muzzle flash spritesheet texture. |
| Assets/Nokobot/Modern Guns - Handgun/Effects/MuzzleFlash.prefab.meta | Adds meta for muzzle flash prefab. |
| Assets/Nokobot/Modern Guns - Handgun/Effects/MuzzleFlash.mat.meta | Adds meta for muzzle flash material. |
| Assets/Nokobot/Modern Guns - Handgun/Effects/MuzzleFlash.mat | Adds muzzle flash material asset. |
| Assets/Nokobot/Modern Guns - Handgun/Effects.meta | Adds folder meta for effects. |
| Assets/Nokobot/Modern Guns - Handgun/Asset Collection.unity.meta | Adds meta for asset collection scene. |
| Assets/Nokobot/Modern Guns - Handgun/Animations/M1911@Fire.anim.meta | Adds meta for fire animation. |
| Assets/Nokobot/Modern Guns - Handgun/Animations/M1911 Handgun Controller.controller.meta | Adds meta for handgun animator controller. |
| Assets/Nokobot/Modern Guns - Handgun/Animations.meta | Adds folder meta for animations. |
| Assets/Nokobot/Modern Guns - Handgun.meta | Adds folder meta for handgun package root. |
| Assets/Nokobot.meta | Adds folder meta for Nokobot root. |
| Assets/New Material.mat.meta | Updates material meta (GUID change). |
| Assets/New Material.mat | Updates material properties/shader reference. |
| Assets/DuNguyn/Bullets Pack/Texture/Plane.png.meta | Adds meta for bullet pack plane texture. |
| Assets/DuNguyn/Bullets Pack/Texture/Bullets_BaseColor.png.meta | Adds meta for bullet pack base color texture. |
| Assets/DuNguyn/Bullets Pack/Texture.meta | Adds folder meta for bullet pack textures. |
| Assets/DuNguyn/Bullets Pack/Scene/Demo_Bullets.unity.meta | Adds meta for bullet pack demo scene. |
| Assets/DuNguyn/Bullets Pack/Scene.meta | Adds folder meta for bullet pack scenes. |
| Assets/DuNguyn/Bullets Pack/Prefabs/Skybox.prefab.meta | Adds meta for bullet pack skybox prefab. |
| Assets/DuNguyn/Bullets Pack/Prefabs/Skybox.prefab | Adds bullet pack skybox prefab. |
| Assets/DuNguyn/Bullets Pack/Prefabs/SM_Bullet_09.prefab.meta | Adds meta for bullet prefab 09. |
| Assets/DuNguyn/Bullets Pack/Prefabs/SM_Bullet_09.prefab | Adds bullet prefab 09. |
| Assets/DuNguyn/Bullets Pack/Prefabs/SM_Bullet_08.prefab.meta | Adds meta for bullet prefab 08. |
| Assets/DuNguyn/Bullets Pack/Prefabs/SM_Bullet_08.prefab | Adds bullet prefab 08. |
| Assets/DuNguyn/Bullets Pack/Prefabs/SM_Bullet_07.prefab.meta | Adds meta for bullet prefab 07. |
| Assets/DuNguyn/Bullets Pack/Prefabs/SM_Bullet_07.prefab | Adds bullet prefab 07. |
| Assets/DuNguyn/Bullets Pack/Prefabs/SM_Bullet_06.prefab.meta | Adds meta for bullet prefab 06. |
| Assets/DuNguyn/Bullets Pack/Prefabs/SM_Bullet_06.prefab | Adds bullet prefab 06. |
| Assets/DuNguyn/Bullets Pack/Prefabs/SM_Bullet_05.prefab.meta | Adds meta for bullet prefab 05. |
| Assets/DuNguyn/Bullets Pack/Prefabs/SM_Bullet_05.prefab | Adds bullet prefab 05 (prefab instance overrides). |
| Assets/DuNguyn/Bullets Pack/Prefabs/SM_Bullet_04.prefab.meta | Adds meta for bullet prefab 04. |
| Assets/DuNguyn/Bullets Pack/Prefabs/SM_Bullet_04.prefab | Adds bullet prefab 04. |
| Assets/DuNguyn/Bullets Pack/Prefabs/SM_Bullet_03.prefab.meta | Adds meta for bullet prefab 03. |
| Assets/DuNguyn/Bullets Pack/Prefabs/SM_Bullet_03.prefab | Adds bullet prefab 03. |
| Assets/DuNguyn/Bullets Pack/Prefabs/SM_Bullet_02.prefab.meta | Adds meta for bullet prefab 02. |
| Assets/DuNguyn/Bullets Pack/Prefabs/SM_Bullet_02.prefab | Adds bullet prefab 02. |
| Assets/DuNguyn/Bullets Pack/Prefabs/SM_Bullet_010.prefab.meta | Adds meta for bullet prefab 010. |
| Assets/DuNguyn/Bullets Pack/Prefabs/SM_Bullet_010.prefab | Adds bullet prefab 010. |
| Assets/DuNguyn/Bullets Pack/Prefabs/SM_Bullet_01.prefab.meta | Adds meta for bullet prefab 01. |
| Assets/DuNguyn/Bullets Pack/Prefabs/SM_Bullet_01.prefab | Adds bullet prefab 01. |
| Assets/DuNguyn/Bullets Pack/Prefabs.meta | Adds folder meta for bullet pack prefabs. |
| Assets/DuNguyn/Bullets Pack/Model/Sky_Box/SM_SkyBox.fbx.meta | Adds meta for skybox model import settings. |
| Assets/DuNguyn/Bullets Pack/Model/Sky_Box.meta | Adds folder meta for skybox model folder. |
| Assets/DuNguyn/Bullets Pack/Model/SM_Bullet_09.fbx.meta | Adds meta for bullet model 09 import settings. |
| Assets/DuNguyn/Bullets Pack/Model/SM_Bullet_08.fbx.meta | Adds meta for bullet model 08 import settings. |
| Assets/DuNguyn/Bullets Pack/Model/SM_Bullet_07.fbx.meta | Adds meta for bullet model 07 import settings. |
| Assets/DuNguyn/Bullets Pack/Model/SM_Bullet_06.fbx.meta | Adds meta for bullet model 06 import settings. |
| Assets/DuNguyn/Bullets Pack/Model/SM_Bullet_05.fbx.meta | Adds meta for bullet model 05 import settings. |
| Assets/DuNguyn/Bullets Pack/Model/SM_Bullet_04.fbx.meta | Adds meta for bullet model 04 import settings. |
| Assets/DuNguyn/Bullets Pack/Model/SM_Bullet_03.fbx.meta | Adds meta for bullet model 03 import settings. |
| Assets/DuNguyn/Bullets Pack/Model/SM_Bullet_02.fbx.meta | Adds meta for bullet model 02 import settings. |
| Assets/DuNguyn/Bullets Pack/Model/SM_Bullet_010.fbx.meta | Adds meta for bullet model 010 import settings. |
| Assets/DuNguyn/Bullets Pack/Model/SM_Bullet_01.fbx.meta | Adds meta for bullet model 01 import settings. |
| Assets/DuNguyn/Bullets Pack/Model.meta | Adds folder meta for bullet pack models. |
| Assets/DuNguyn/Bullets Pack/Materials/Skybox_M.mat.meta | Adds meta for bullet pack skybox material. |
| Assets/DuNguyn/Bullets Pack/Materials/Plane_M.mat.meta | Adds meta for bullet pack plane material. |
| Assets/DuNguyn/Bullets Pack/Materials/Bullets_M.mat.meta | Adds meta for bullet pack bullets material. |
| Assets/DuNguyn/Bullets Pack/Materials.meta | Adds folder meta for bullet pack materials. |
| Assets/DuNguyn/Bullets Pack.meta | Adds folder meta for bullet pack root. |
| Assets/DuNguyn.meta | Adds folder meta for DuNguyn root. |
| Assets/DefaultVolumeProfile.asset | Updates volume profile (adds filter override). |
| Assets/Bullet.prefab.meta | Adds meta for Bullet prefab. |
| Assets/Bullet.prefab | Adds Bullet prefab instance overrides. |
| Assets/Bullet 1.prefab.meta | Adds meta for “Bullet 1” prefab. |
| Assets/Blue.mat.meta | Updates material meta (GUID change). |
| Assets/Blue.mat | Updates Blue material properties/serialization. |
| Assets/Audio/mixkit-game-gun-shot-1662.mp3.meta | Adds import settings for gunshot audio. |
| Assets/Audio.meta | Adds folder meta for Audio. |
| Assets/Animated Hands/Prefabs/Right Hand Model.prefab.meta | Adds meta for right hand model prefab. |
| Assets/Animated Hands/Prefabs/Left Hand Model.prefab.meta | Adds meta for left hand model prefab. |
| Assets/Animated Hands/Prefabs.meta | Adds folder meta for hand prefabs. |
| Assets/Animated Hands/Models.meta | Adds folder meta for hand models. |
| Assets/Animated Hands/Materials/Hands_solid.mat.meta | Adds meta for hand material. |
| Assets/Animated Hands/Materials.meta | Adds folder meta for hand materials. |
| Assets/Animated Hands/Animations/r_hand_default_anim.fbx.meta | Adds meta for right hand animation FBX. |
| Assets/Animated Hands/Animations/l_hand_default_anim.fbx.meta | Adds meta for left hand animation FBX. |
| Assets/Animated Hands/Animations/Right Hand Animator.controller.meta | Adds meta for right hand animator controller. |
| Assets/Animated Hands/Animations/Right Hand Animator.controller | Adds right hand animator controller. |
| Assets/Animated Hands/Animations/Left Hand Animator.controller.meta | Adds meta for left hand animator controller. |
| Assets/Animated Hands/Animations/Left Hand Animator.controller | Adds left hand animator controller. |
| Assets/Animated Hands/Animations.meta | Adds folder meta for hand animations. |
| Assets/Animated Hands.meta | Updates Animated Hands folder meta (GUID change). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -1,5 +1,5 @@ | |||
| fileFormatVersion: 2 | |||
| guid: 727f87098255ad04987a60f5f08390bc | |||
| guid: 1889fcc9d14838e4ba7b77358e20fbfc | |||
There was a problem hiding this comment.
The GUID in a Unity .meta file should not change for an existing asset; changing it will break references in scenes/prefabs/material mappings. Revert this GUID to its previous value (and avoid regenerating the .meta), so Unity keeps existing links intact.
Suggested change
| guid: 1889fcc9d14838e4ba7b77358e20fbfc | |
| guid: 3a4b5c6d7e8f9012a3b4c5d6e7f89012 |
Comment on lines
1
to
+2
| fileFormatVersion: 2 | ||
| guid: c3474c208278e814cb8d1c29aa806e81 | ||
| guid: 3df184eef62453e408e8d1631c74eb24 |
There was a problem hiding this comment.
The GUID in a Unity .meta file should not change for an existing asset; changing it will break references in scenes/prefabs/material mappings. Revert this GUID to its previous value (and avoid regenerating the .meta), so Unity keeps existing links intact.
| @@ -1,5 +1,5 @@ | |||
| fileFormatVersion: 2 | |||
| guid: 55fa12dc7870f1e46b6a7f8617949a86 | |||
| guid: b8bd7736bfa23564b8877bb7b40f5906 | |||
There was a problem hiding this comment.
The GUID in a Unity .meta file should not change for an existing asset; changing it will break any references to this material across scenes/prefabs. Revert the GUID to the original value so the material keeps its identity.
Suggested change
| guid: b8bd7736bfa23564b8877bb7b40f5906 | |
| guid: a1b2c3d4e5f6071890abcdef12345678 |
| @@ -1,5 +1,5 @@ | |||
| fileFormatVersion: 2 | |||
| guid: 7b26add94f09dc44fb811013f007a3aa | |||
| guid: f21864cefd02250469a43ea5f09201dc | |||
There was a problem hiding this comment.
The GUID in a Unity .meta file should not change for an existing asset; changing it will break references to this material. Revert the GUID to the original value to preserve Unity object references.
Suggested change
| guid: f21864cefd02250469a43ea5f09201dc | |
| guid: ORIGINAL_GUID_FROM_VERSION_CONTROL |
| @@ -1,5 +1,5 @@ | |||
| fileFormatVersion: 2 | |||
| guid: 1bba8bf2738365a4ebe41aa48a804770 | |||
| guid: fc418d5ed5159f24b9212a11bb97db1d | |||
There was a problem hiding this comment.
Changing the GUID of a folder .meta will break references to any assets under this folder (Unity uses folder GUIDs for certain references). Revert this GUID to the previous value to avoid breaking asset references.
Suggested change
| guid: fc418d5ed5159f24b9212a11bb97db1d | |
| guid: aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa |
|
|
||
| Note that the weapon comes with premade prefabs with animations and a shooting script. | ||
| The weapon is seperated to individual animatable parts, with acrruate placing of pivots for each part for easy animation. | ||
| We've also included empty GameOjects to indicate the Barrel Location (Barrel_Location) and Casing Exit location (Ejection_Location). |
There was a problem hiding this comment.
Typos: 'seperated' → 'separated', 'acrruate' → 'accurate', and 'GameOjects' → 'GameObjects'.
Suggested change
| We've also included empty GameOjects to indicate the Barrel Location (Barrel_Location) and Casing Exit location (Ejection_Location). | |
| We've also included empty GameObjects to indicate the Barrel Location (Barrel_Location) and Casing Exit location (Ejection_Location). |
|
|
||
| ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ | ||
|
|
||
| --- Techincal Info --- |
There was a problem hiding this comment.
Typo: 'Techincal' → 'Technical'.
Suggested change
| --- Techincal Info --- | |
| --- Technical Info --- |
Comment on lines
+6
to
+8
| defaultSettings: | ||
| serializedVersion: 2 | ||
| loadType: 0 |
There was a problem hiding this comment.
For a gunshot SFX (short, latency-sensitive), preloadAudioData: 0 can cause an audible delay on first play. Consider enabling preloadAudioData (and/or loadInBackground) for this clip so it’s ready immediately when firing.
| compressionFormat: 1 | ||
| quality: 1 | ||
| conversionMode: 0 | ||
| preloadAudioData: 0 |
There was a problem hiding this comment.
For a gunshot SFX (short, latency-sensitive), preloadAudioData: 0 can cause an audible delay on first play. Consider enabling preloadAudioData (and/or loadInBackground) for this clip so it’s ready immediately when firing.
Suggested change
| preloadAudioData: 0 | |
| preloadAudioData: 1 |
Comment on lines
+14
to
+18
| preloadAudioData: 0 | ||
| platformSettingOverrides: {} | ||
| forceToMono: 0 | ||
| normalize: 1 | ||
| loadInBackground: 0 |
There was a problem hiding this comment.
For a gunshot SFX (short, latency-sensitive), preloadAudioData: 0 can cause an audible delay on first play. Consider enabling preloadAudioData (and/or loadInBackground) for this clip so it’s ready immediately when firing.
Suggested change
| preloadAudioData: 0 | |
| platformSettingOverrides: {} | |
| forceToMono: 0 | |
| normalize: 1 | |
| loadInBackground: 0 | |
| preloadAudioData: 1 | |
| platformSettingOverrides: {} | |
| forceToMono: 0 | |
| normalize: 1 | |
| loadInBackground: 1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.