Fix startup code#20
Open
afuechsel wants to merge 3 commits into
Open
Conversation
Author
|
@SudKul Please have a look on my PR. I think, it's now much better. Docker compose can be used for the ease of development and swagger models are correctly documents. POST endpoints can now be used in swagger as they document their request payload properly. The things I couldn't fix, due to my limited python knowledge are:
|
Author
|
@SudKul the PR is open long since, my project based on the improvements here has been accepted long ago, so why is the MR still open and not merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improvement for the starter code: