fix: make create mutation input fields optional for beforeCreate hooks #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the create mutation's input validator required all schema fields, causing validation errors when beforeCreate hooks tried to add required fields. This change uses partial() to make all input fields optional during validation, allowing beforeCreate hooks to add or modify any required fields. The actual schema validation still occurs when inserting into the database. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
🦋 Changeset detectedLatest commit: bdb2151 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem
The create mutation's input validator was requiring all schema fields to be present before the beforeCreate hook could run. This caused validation errors when beforeCreate hooks tried to add required fields (like auto-generating usernames).
Solution
Used
partial()from convex-helpers to make all input fields optional during the validation phase. The actual schema validation still happens when inserting into the database, maintaining data integrity.Test plan
🤖 Generated with Claude Code