Skip to content

Conversation

@12joan
Copy link
Collaborator

@12joan 12joan commented Jun 26, 2025

Checklist

  • yarn typecheck
  • yarn lint:fix
  • yarn test
  • yarn brl
  • yarn changeset
  • ui changelog

@codesandbox
Copy link

codesandbox bot commented Jun 26, 2025

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@changeset-bot
Copy link

changeset-bot bot commented Jun 26, 2025

🦋 Changeset detected

Latest commit: b105873

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@platejs/core Patch
platejs Patch
@platejs/utils Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jun 26, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
plate 🛑 Canceled (Inspect) Jun 26, 2025 6:06pm

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. performance issue labels Jun 26, 2025
@zbeyens zbeyens merged commit dfb6474 into main Jun 26, 2025
9 checks passed
@zbeyens zbeyens deleted the perf/fallback-store branch June 26, 2025 18:11
@ZhangMingZhao1
Copy link

@claude Explain in detail how this commit optimizes performance issues

@zbeyens
Copy link
Member

zbeyens commented Jul 2, 2025

Claude requires to have a subscription, so I can't make it accessible to everyone. You can tag dosu however.

@zbeyens
Copy link
Member

zbeyens commented Jul 2, 2025

@dosu Explain in detail how this commit optimizes performance issues

@12joan
Copy link
Collaborator Author

12joan commented Jul 2, 2025

@claude Explain in detail how this commit optimizes performance issues

It wasn't so much of a problem before, but my recent jotai-x PR udecode/jotai-x#33 transferred much of the computational complexity from useStoreApi to createAtomStore, which means we now need to be mindful of the number of times createAtomStore is called.

@ZhangMingZhao1
Copy link

ZhangMingZhao1 commented Jul 2, 2025

@zbeyens @12joan Thanks for explaining

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

performance issue size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants