-
Notifications
You must be signed in to change notification settings - Fork 937
bun #4737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Replace incompatible `bun workspace <name> <script>` commands with `bun --cwd <path> run <script>` pattern that works with Bun. Changes: - package.json: Updated 6 scripts (build:tw, devt, r, rd, shadcn:build, test:r) - CLAUDE.md: Updated documentation to show correct Bun workspace usage Fixes: Script not found "workspace" errors 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Replace bun --cwd commands with turbo --filter for better consistency with the monorepo's existing patterns. Changes: - package.json: Use turbo --filter=www for all workspace scripts - CLAUDE.md: Update documentation to show turbo filter pattern Benefits: - More consistent with existing monorepo commands - Works seamlessly with Turbo's caching and task orchestration - Simpler and more maintainable 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Add type annotations to fix implicit 'any' errors and property access issues throughout the www application. Changes: - scripts: Add 'any' types to callback parameters in build scripts - docs pages: Fix implicit 'any' in array callbacks and key access - API routes: Add type annotation to destructuring parameter - block-viewer: Fix property access on file objects with type assertions - lib utilities: Add 'any' types to callbacks and fix zod schema Note: Contentlayer2 has a known Zod v4 compatibility issue that prevents the build from completing. This is documented in ZOD_ISSUE.md and is not related to these TypeScript fixes. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
- Replace 'yarn shadcn:' with 'bun run shadcn:' in build-registry.mts - Separate typecheck and test steps in CI workflow for better debugging - Clean up generated registry files (will be rebuilt) This fixes the Vercel build failure where the script was trying to execute 'yarn shadcn:build' instead of 'bun run shadcn:build'. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Replace all Yarn references with Bun in both English and Chinese CONTRIBUTING.md files: - Updated package manager references from Yarn to Bun - Changed all yarn commands to bun commands - Updated workspace documentation links - Changed yarn install → bun install - Changed yarn build → bun run build - Changed yarn test → bun run test - Changed yarn lint → bun run lint - Changed yarn e2e → bun run e2e - Changed yarn brl → bun run brl - Changed yarn gen:package → bun run gen:package - Updated component installation from yarn g:plate-ui → bunx shadcn 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Configure Vercel to use Bun for installation and building: - buildCommand: bun run build && turbo build --filter=www - installCommand: bun install - framework: nextjs Note: Node.js version must be set to 22.x in Vercel project settings. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
|
bun + turbopack does not work here. will go for pnpm in the meantime. |
|
pnpm: same issue with turbopack |
Summary
Complete migration from Yarn 4.6.0 to Bun 1.3.2 as the package manager for the Plate monorepo.
Key Changes
yarn.lockwithbun.lock(6,023 entries).yarnrc.yml,.yarn/directory)package.jsonscripts to usebuncommandsbun-installGitHub Action and updated all workflowsCLAUDE.md, tech stack documentation, and READMEFiles Changed
Removed:
.yarnrc.ymlyarn.lock(22,275 lines).yarn/plugins/and.yarn/releases/.github/actions/yarn-nm-install/Created:
bun.lock(6,023 entries).github/actions/bun-install/action.yml.claude/docs/plans/yarn-to-bun-migration-plan.mdZOD_ISSUE.md(documenting known issue)Modified:
package.json(packageManager, engines, all scripts)package.jsonfiles.github/workflows/*.yml)CLAUDE.md(command documentation).cursor/rules/tech-stack.mdcBenefits
Verification
Breaking Changes
For Contributors:
yarncommands withbunnpxwithbunxFor CI/CD:
oven-sh/setup-bun@v2actionbun.lockMigration Commands
Test Plan
rm -rf node_modules && bun installbun buildbun typecheckbun checkbun testKnown Issues
ZOD_ISSUE.md)Rollback Plan
If issues arise:
git revert ae6271b1eyarn install(will recreateyarn.lock)yarn buildReferences
.claude/docs/plans/yarn-to-bun-migration-plan.md🤖 Generated with Claude Code
Co-Authored-By: Claude [email protected]