-
Notifications
You must be signed in to change notification settings - Fork 937
Templates v52 #4754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Templates v52 #4754
Conversation
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
plate/.github/workflows/sync-templates.yml
Lines 51 to 55 in cabb1e7
| - name: 📥 Install dependencies | |
| run: pnpm install --no-frozen-lockfile | |
| - name: 🏗 Build | |
| run: pnpm build |
Templates now declare packageManager: [email protected] and run bunx in postinstall, but this workflow still installs pnpm and runs pnpm install/pnpm build without installing bun. When the job builds the templates, pnpm will execute the bun-based lifecycle scripts and fail due to the missing runtime and lockfile mismatch. Switch the workflow to install bun and use bun install (or otherwise provide bun) so the templates can build.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Checklist
yarn typecheckyarn lint:fixyarn testyarn brlyarn changeset