Skip to content

Conversation

@zbeyens
Copy link
Member

@zbeyens zbeyens commented Nov 24, 2025

Checklist

  • yarn typecheck
  • yarn lint:fix
  • yarn test
  • yarn brl
  • yarn changeset
  • ui changelog

@codesandbox
Copy link

codesandbox bot commented Nov 24, 2025

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@changeset-bot
Copy link

changeset-bot bot commented Nov 24, 2025

⚠️ No Changeset found

Latest commit: a17dcfa

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Nov 24, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
plate Ready Ready Preview Comment Nov 24, 2025 6:36pm

@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. maintenance labels Nov 24, 2025
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

- name: 📥 Install dependencies
run: pnpm install --no-frozen-lockfile
- name: 🏗 Build
run: pnpm build

P1 Badge Build templates with bun instead of pnpm

Templates now declare packageManager: [email protected] and run bunx in postinstall, but this workflow still installs pnpm and runs pnpm install/pnpm build without installing bun. When the job builds the templates, pnpm will execute the bun-based lifecycle scripts and fail due to the missing runtime and lockfile mismatch. Switch the workflow to install bun and use bun install (or otherwise provide bun) so the templates can build.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@zbeyens zbeyens merged commit 75d5944 into main Nov 24, 2025
3 of 4 checks passed
@zbeyens zbeyens deleted the templates/52 branch November 24, 2025 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance size:XXL This PR changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants