fix(markdown): expand marked version range to support marked v18 (#5060) - #5078
Closed
Samarth1306w wants to merge 1 commit into
Closed
fix(markdown): expand marked version range to support marked v18 (#5060)#5078Samarth1306w wants to merge 1 commit into
Samarth1306w wants to merge 1 commit into
Conversation
@platejs/markdown pinned marked to ^15.0.12, causing applications using marked v18 to ship duplicate versions of marked in their bundle and lockfile. Fix: - Expand marked dependency version specifier in package.json to ^15.0.12 || ^16.0.0 || ^17.0.0 || ^18.0.0. - Add patch changeset for @platejs/markdown. Closes #5060
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
1 similar comment
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
🦋 Changeset detectedLatest commit: ef997e6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dosubot
Bot
added
size:XS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Summary
Fixes #5060 — marked fixed to v15 in
@platejs/markdowncausing duplicate lockfile entries for marked v18 users.🔍 Root Cause Analysis
@platejs/markdownpinnedmarkedto^15.0.12in dependencies. Projects usingmarkedv18 (or v16/v17) were forced to ship duplicate versions of themarkedlibrary in their bundle and lockfile.🛠️ Surgical Patch Breakdown
packages/markdown/package.json:Expanded
markeddependency specifier to^15.0.12 || ^16.0.0 || ^17.0.0 || ^18.0.0, allowing projects using marked v15 through v18 to reuse a single dependency instance..changeset/fix-markdown-marked-v18-version-range.md: Added patch changeset for@platejs/markdown.🧪 Verification & Test Coverage
@platejs/markdown.mainwith 0 conflicts.