Skip to content

Conversation

@a-gubskiy
Copy link
Member

@a-gubskiy a-gubskiy commented Aug 18, 2025

This pull request removes [Obsolete] attribute annotations from the PagedListMetaData class and its related GetMetaData methods. These changes indicate that the class and methods are no longer marked for future removal, making them officially supported again.

API status updates:

  • Removed the [Obsolete] attribute from the PagedListMetaData class in PagedListMetaData.cs, making it officially supported.
  • Removed the [Obsolete] attribute from the GetMetaData method in the IPagedList<T> interface in IPagedList.cs.
  • Removed the [Obsolete] attribute from the GetMetaData method implementation in BasePagedList.cs.…tation

Summary by CodeRabbit

  • Refactor
    • Removed obsolete/deprecation markings from pagination metadata types and the related API method. Signatures and behavior remain unchanged.
    • Eliminates deprecation warnings in consuming projects and clarifies continued support for these APIs.

@a-gubskiy a-gubskiy requested a review from Copilot August 18, 2025 09:17
@coderabbitai
Copy link

coderabbitai bot commented Aug 18, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Removed Obsolete attributes from PagedList metadata API: un-deprecated PagedListMetaData class and GetMetaData() on IPagedList and BasePagedList. No signatures or logic changed.

Changes

Cohort / File(s) Summary of Changes
Un-deprecate PagedList metadata API
src/X.PagedList/BasePagedList.cs, src/X.PagedList/IPagedList.cs, src/X.PagedList/PagedListMetaData.cs
Removed [Obsolete(...)] attributes from PagedListMetaData class and GetMetaData() in IPagedList and BasePagedList; no functional changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

I thump my paws—no warning tags today,
The meta’s back, hip-hop hooray!
Pages turn with cleaner air,
No dusty labels lingering there.
I nibble code like clover sweet—
Deprecated woes? Hopped off their feet. 🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 4a9c349 and 87f2025.

📒 Files selected for processing (3)
  • src/X.PagedList/BasePagedList.cs (0 hunks)
  • src/X.PagedList/IPagedList.cs (0 hunks)
  • src/X.PagedList/PagedListMetaData.cs (0 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch remove-deprecation

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@a-gubskiy a-gubskiy linked an issue Aug 18, 2025 that may be closed by this pull request
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request reinstates the PagedListMetaData class and its related GetMetaData methods by removing their [Obsolete] attributes, indicating they are no longer planned for removal and are officially supported again.

  • Removed [Obsolete] attribute from PagedListMetaData class
  • Removed [Obsolete] attribute from GetMetaData method in interface and implementation
  • Restored official support for metadata functionality in the paged list library

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
PagedListMetaData.cs Removed obsolete marking from the PagedListMetaData class
IPagedList.cs Removed obsolete marking from GetMetaData method interface declaration
BasePagedList.cs Removed obsolete marking from GetMetaData method implementation

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@a-gubskiy a-gubskiy self-assigned this Aug 18, 2025
@a-gubskiy a-gubskiy merged commit 5a8c74e into master Aug 18, 2025
3 of 4 checks passed
@a-gubskiy a-gubskiy deleted the remove-deprecation branch August 18, 2025 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

Question about the GetMetaData() method

1 participant