-
-
Notifications
You must be signed in to change notification settings - Fork 220
Request removes [Obsolete] attribute #340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Caution Review failedThe pull request is closed. WalkthroughRemoved Obsolete attributes from PagedList metadata API: un-deprecated PagedListMetaData class and GetMetaData() on IPagedList and BasePagedList. No signatures or logic changed. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. 📒 Files selected for processing (3)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request reinstates the PagedListMetaData class and its related GetMetaData methods by removing their [Obsolete] attributes, indicating they are no longer planned for removal and are officially supported again.
- Removed
[Obsolete]attribute fromPagedListMetaDataclass - Removed
[Obsolete]attribute fromGetMetaDatamethod in interface and implementation - Restored official support for metadata functionality in the paged list library
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| PagedListMetaData.cs | Removed obsolete marking from the PagedListMetaData class |
| IPagedList.cs | Removed obsolete marking from GetMetaData method interface declaration |
| BasePagedList.cs | Removed obsolete marking from GetMetaData method implementation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This pull request removes
[Obsolete]attribute annotations from thePagedListMetaDataclass and its relatedGetMetaDatamethods. These changes indicate that the class and methods are no longer marked for future removal, making them officially supported again.API status updates:
[Obsolete]attribute from thePagedListMetaDataclass inPagedListMetaData.cs, making it officially supported.[Obsolete]attribute from theGetMetaDatamethod in theIPagedList<T>interface inIPagedList.cs.[Obsolete]attribute from theGetMetaDatamethod implementation inBasePagedList.cs.…tationSummary by CodeRabbit