Always add sort as a vertex to the graph in case it is a simple enum#30
Open
yiyunliu wants to merge 1 commit intouds-psl:rocq-9.0from
Open
Always add sort as a vertex to the graph in case it is a simple enum#30yiyunliu wants to merge 1 commit intouds-psl:rocq-9.0from
yiyunliu wants to merge 1 commit intouds-psl:rocq-9.0from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch should fix the issue mentioned in #28
The culprit is the
build_graphfunction, which won't add enum sorts as vertices to the graph through theadd_edgefunction as their constructors don't have any arguments (and thus have no edges).When
G.succinbuild_signaturegets called later, an exception would be thrown because the enum vertex is never inserted.