Skip to content

Conversation

@goDeni
Copy link
Collaborator

@goDeni goDeni commented May 9, 2025

No description provided.

@goDeni goDeni force-pushed the our-js branch 2 times, most recently from 586a5dd to 9a4faaa Compare May 9, 2025 07:42
@goDeni goDeni marked this pull request as ready for review May 9, 2025 07:45
@goDeni goDeni requested a review from mikhailantoshkin May 9, 2025 07:45
@goDeni goDeni enabled auto-merge (rebase) May 9, 2025 07:52
@mikhailantoshkin
Copy link
Collaborator

oh yeah, 20.04 runners are depricated, i'll port changes from udv-group/netflow-gen#2 in a sec to fix CI

Copy link
Collaborator

@mikhailantoshkin mikhailantoshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very good, I sense a great deal of pain with this change)

you should probably document the process sometime

LGTM, with few change requests we also discussed in DMs

@mikhailantoshkin
Copy link
Collaborator

ci fix is in #63

@goDeni goDeni disabled auto-merge May 9, 2025 13:55
@goDeni goDeni self-assigned this May 10, 2025
@goDeni goDeni requested a review from mikhailantoshkin May 10, 2025 03:58
@goDeni goDeni enabled auto-merge (rebase) May 10, 2025 03:58
@goDeni goDeni merged commit d017d60 into main May 10, 2025
8 checks passed
@goDeni goDeni deleted the our-js branch May 10, 2025 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants