feat: add generic Context support across server classes and hooks#1057
Merged
feat: add generic Context support across server classes and hooks#1057
Context support across server classes and hooks#1057Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds generic Context type support across the Hocuspocus server classes and hook system, enabling type-safe context passing throughout the application lifecycle. The changes maintain backward compatibility by defaulting the generic type parameter to any.
Changes:
- Added generic
<Context = any>type parameter to core classes (Server,Hocuspocus,Connection,DirectConnection,ClientConnection) and interfaces (Extension,Configuration) - Updated all context-aware hook payload interfaces to use the generic
Contexttype parameter - Modified method signatures to properly propagate the generic Context type through the call chain
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/server/src/types.ts | Added generic Context parameter to Extension, Configuration, HookPayloadByName, and all context-aware payload interfaces |
| packages/server/src/Server.ts | Added generic Context parameter to ServerConfiguration interface and Server class |
| packages/server/src/Hocuspocus.ts | Added generic Context parameter to Hocuspocus class and updated method signatures for type-safe context handling |
| packages/server/src/DirectConnection.ts | Added generic Context parameter to DirectConnection class with type assertion for default empty context |
| packages/server/src/Connection.ts | Added generic Context parameter to Connection class |
| packages/server/src/ClientConnection.ts | Added generic Context parameter to ClientConnection class and updated callback type signatures |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.