feat: first draft of @hocuspocus/provider-react package#1059
Open
feat: first draft of @hocuspocus/provider-react package#1059
Conversation
janthurau
force-pushed
the
feat/provider-react
branch
from
f558b20 to
66de275
Compare
janthurau
changed the title
janthurau
force-pushed
the
feat/provider-react
branch
from
66de275 to
14da897
Compare
janthurau
force-pushed
the
feat/provider-react
branch
from
14da897 to
3b8add4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The idea of this package is to remove all issues around rerendering during development in React. Strict mode triggers hooks twice, which is confusing (the network tab shows two websockets, one is dead and another is connected), and can cause timing issues (the server doesnt support opening the same document name twice over the same websocket connection), so if a disconnect and connect happen really fast, the state may mix and connections break.
Status: Needs careful testing.