Open
Conversation
update to tailwind v4 apply dark
|
@ospira is attempting to deploy a commit to the Tiptap Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sometimes it is late at night and we wish to read the tiptap docs...
you load it up and the lack of dark mode burns your eyeballs...
but as you can see, luckily i have already provisioned this fix.
note if this is agreeable to you i would also want a diff on this line: https://github.com/ueberdosis/tiptap/blob/d77192b70f62a5a3df98bb4c58729b630a002e23/demos/preview/Demo.vue#L19 (embedded examples still burn my eyes)
tailwind was updated to v4 to facilitate this.
visual diff added below:
before (my dark mode is always enabled... but it is blinding white, my eyes burn 🔥😭)
after (my device settings are respected and now i can investigate 🧐✨)