Fix Suggestion Utility isChangeOrigin Usage#715
Open
n-siddarth wants to merge 3 commits intoueberdosis:mainfrom
Open
Fix Suggestion Utility isChangeOrigin Usage#715n-siddarth wants to merge 3 commits intoueberdosis:mainfrom
n-siddarth wants to merge 3 commits intoueberdosis:mainfrom
Conversation
`isChangeOrigin` indicates whether a transaction was made from remote (yjs change). We want to disable showing the suggestion popup if this condition is met, requiring the negation.
|
@n-siddarth is attempting to deploy a commit to the Tiptap Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
isChangeOriginindicates whether a transaction was created from remote (yjs). We want to disable showing the suggestion popup when this condition is met, so a negation is required.