Fixed mergeAttributes utility for correct merge of inline styles #6283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e0e025c The changes in this PR will be included in the next version bump. This PR includes changesets to release 54 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for tiptap-embed ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Overview
The style attribute merge does not work correctly in some cases. For example, if the inline style contains a link to a background image, a simple colon split of the string is not suitable for splitting the string into keys and values. This results in invalid styles.
I've updated the test for the mergeAttributes utility, it clearly shows which cases will not work correctly.
Implementation Approach
The styles property key is obtained by the first colon index, anything after it is considered a value. Only non-empty keys and values are included in the result.
Testing Done
Updated the test for the mergeAttributes utility, added several cases to check for corrupted styles, as well as styles with background images and font families.
Verification Steps
The problem is noticeable when adding custom attributes based on styles. In my work, I need to preserve styles from the input HTML as much as possible, since I'm working on a visual email editor.
Checklist