Fix autofocus behavior to prevent unwanted scrolling when disabled#6864
Closed
Fix autofocus behavior to prevent unwanted scrolling when disabled#6864
Conversation
|
✅ Deploy Preview for tiptap-embed ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Copilot
AI
changed the title
[WIP] I want to work on issue @ueberdosis/tiptap/issues/4235
Fix autofocus behavior to prevent unwanted scrolling when disabled
Aug 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #4235 where setting
autofocus: falseorautofocus: nullstill caused the page to scroll to the editor on mount.Problem
The editor was unconditionally calling the focus command during initialization, even when autofocus was explicitly disabled:
This caused unwanted scrolling behavior when editors were positioned below the fold, particularly problematic in modals or long forms where users didn't want the page to jump to the editor.
Solution
Added a conditional check to only call the focus command when autofocus should actually focus the editor:
This ensures:
autofocus: false- No focus/scroll behavior ✅autofocus: null- No focus/scroll behavior ✅autofocus: true- Focuses at start (existing behavior) ✅autofocus: 'start'- Focuses at start ✅autofocus: 'end'- Focuses at end ✅autofocus: number- Focuses at position ✅Testing
autofocus: truedemos/src/Extensions/AutofocusTest/React/The fix is minimal and surgical, addressing the exact issue without breaking any existing functionality.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
download.cypress.ionode index.js --exec install(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.