Improvements to Heuristic for Abandoned Amazon S3 Buckets#61
Merged
anavirginianery merged 12 commits intodevfrom Feb 9, 2026
Merged
Improvements to Heuristic for Abandoned Amazon S3 Buckets#61anavirginianery merged 12 commits intodevfrom
anavirginianery merged 12 commits intodevfrom
Conversation
jhenriwue
requested review from
Geraldo155,
anavirginianery,
caetanobca,
gabrielecalafange,
marianezei and
nicolasrbr
gabrielecalafange
approved these changes
Dec 16, 2025
Geraldo155
requested changes
Dec 16, 2025
bumiworker/bumiworker/modules/recommendations/s3_abandoned_buckets.py
Outdated
Show resolved
Hide resolved
marianezei
reviewed
Jan 19, 2026
Comment on lines
-12
to
-15
| [THRESHOLD_INPUT_NAMES.DAYS_THRESHOLD]: "days_threshold", | ||
| [THRESHOLD_INPUT_NAMES.DATA_SIZE_THRESHOLD]: "data_size_threshold", | ||
| [THRESHOLD_INPUT_NAMES.TIER_1_REQUESTS_QUANTITY_THRESHOLD]: "tier_1_request_quantity_threshold", | ||
| [THRESHOLD_INPUT_NAMES.TIER_2_REQUESTS_QUANTITY_THRESHOLD]: "tier_2_request_quantity_threshold" |
Collaborator
There was a problem hiding this comment.
will these removals have a negative impact on the system?
this happens throughout the code.
Collaborator
There was a problem hiding this comment.
They are used as placeholders on the frontend. So it should be fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces enhancements to the heuristic used to determine when an S3 bucket is abandoned
Previous Behavior
Previously, the system had a hierarchy of request types and a threshold for each tier. Tier 1 included list, delete, put, and other types of requests, while tier 2 only included get requests. The amount of data transferred was also taken into consideration.
New Logic
Now the system only considers PUT and GET request types. It disregards any other request type besides these two when determining whether a bucket should be recommended or not.