-
Notifications
You must be signed in to change notification settings - Fork 126
[WIP] RT updates: Move to control file, run from master rt.sh for all testing, beginning of shellcheck linting #1090
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
[WIP] RT updates: Move to control file, run from master rt.sh for all testing, beginning of shellcheck linting #1090
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a similar script in ./sorc - machine-setup.sh. Can we combine them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The detect_machine script would take over the setting of ${target} in sorc/machine-setup.sh. Specifically detect_machine.sh is maintained at the UFSWM level and shared with global workflow. So it makes some sense to try the same approach with UFS_UTILS.
The UFSWM has a separate script in their testing similar to sorc/machine-setup.sh at https://github.com/ufs-community/ufs-weather-model/blob/develop/tests/module-setup.sh
It might be worthwhile to share UFSWM's module-setup.sh instead of maintaining two separate versions.
What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No problem sharing code. Can we link to a single file in another repo? Or do you plan to keep a local copy in UFS_UTILS?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lots of people maintaining UFSWM, it should reside there and we copy it. Future thinking might be some ufs-community maintained repo like "hpc-tools" where g-w ufswm ufs_utils etc can make use as a submodule?
|
@GeorgeGayno-NOAA completely runs in ~25 minutes I need to test adding CHANGE_BASELINES to rt.control and change some of the calls to accept an exported env var. Then hopefully things don't fail. |
|
I've tested this on Ursa using the UPDATE_BASELINE=True and it works! |
DESCRIPTION OF CHANGES:
RT updates:
TESTS CONDUCTED:
If there are changes to the build or source code, the tests below must be conducted. Contact a repository manager if you need assistance.
Describe any additional tests performed:
DEPENDENCIES:
DOCUMENTATION:
All new and updated source code must be documented with Doxygen.
If this PR is contributing new capabilities that need to be documented, please also include updates to the RST files in the docs/source directory as supporting material.
ISSUE: