Skip to content

Conversation

@BrianCurtis-NOAA
Copy link
Collaborator

DESCRIPTION OF CHANGES:

RT updates:

  • Move to control file, users only have to change variables in one place for testing.
  • Run from master rt.sh for all testing
  • beginning of shellcheck linting (adding .shellcheckrc for eventual superlinter addition later)

TESTS CONDUCTED:

If there are changes to the build or source code, the tests below must be conducted. Contact a repository manager if you need assistance.

  • Compile with Doxygen on any machine with no errors.
  • Run relevant consistency tests locally on all Tier 1 machines.

Describe any additional tests performed:

DEPENDENCIES:

  • None

DOCUMENTATION:

All new and updated source code must be documented with Doxygen.

  • Doxygen is updated.

If this PR is contributing new capabilities that need to be documented, please also include updates to the RST files in the docs/source directory as supporting material.

ISSUE:

  • None

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a similar script in ./sorc - machine-setup.sh. Can we combine them?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The detect_machine script would take over the setting of ${target} in sorc/machine-setup.sh. Specifically detect_machine.sh is maintained at the UFSWM level and shared with global workflow. So it makes some sense to try the same approach with UFS_UTILS.

The UFSWM has a separate script in their testing similar to sorc/machine-setup.sh at https://github.com/ufs-community/ufs-weather-model/blob/develop/tests/module-setup.sh

It might be worthwhile to share UFSWM's module-setup.sh instead of maintaining two separate versions.

What do you think?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem sharing code. Can we link to a single file in another repo? Or do you plan to keep a local copy in UFS_UTILS?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lots of people maintaining UFSWM, it should reside there and we copy it. Future thinking might be some ufs-community maintained repo like "hpc-tools" where g-w ufswm ufs_utils etc can make use as a submodule?

@BrianCurtis-NOAA
Copy link
Collaborator Author

@GeorgeGayno-NOAA completely runs in ~25 minutes

Started on ufe03
Commit hash: ef8ea2656c70666c7b6004fdb6a10babd8c0255b

regrid_sfc consistency tests PASSED
weight_gen consistency tests PASSED
ocnice_prep consistency tests PASSED
cpld_gridgen consistency tests PASSED
chgres_cube consistency tests PASSED
grid_gen consistency tests PASSED
global_cycle consistency tests PASSED
ice_blend consistency tests PASSED
snow2mdl consistency tests PASSED
Total elapsed time: 24 minutes and 56 seconds
Finished on ursa

I need to test adding CHANGE_BASELINES to rt.control and change some of the calls to accept an exported env var. Then hopefully things don't fail.

@BrianCurtis-NOAA BrianCurtis-NOAA mentioned this pull request Sep 19, 2025
8 tasks
@BrianCurtis-NOAA
Copy link
Collaborator Author

I've tested this on Ursa using the UPDATE_BASELINE=True and it works!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants