Add timers to WW3 cap#2086
Closed
DeniseWorthen wants to merge 4 commits intoufs-community:developfrom
Closed
Conversation
* created a duplicate mx100 mod_def with timesteps set as "outer-loop". Ran tests associated with this mod_def, adding config variable dt_in=720,360,360,30 to the wave attributes. All tests pass. Message generated
4 tasks
4 tasks
Collaborator
Author
|
Combined with #2085, closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Queue Requirements:
PR Information
Description
Fixes a potential divide-by-zero when WAV-ICE coupling is enabled in UWM.
Updates WW3 to enable run timers in the cap. As with the CICE and MOM6 caps, the feature is enabled by setting
RunTimeLog = truein the ALLCOMP_attributes.The timer log will be
log.ww3.timerwhich will showAlso adds the capability of reading a WW3 configuration attribute to allow WW3 timesteps to over-write timesteps saved in pre-created mod_def file. This allows the same mod_def file to be used for either inner or outer loop coupling. To test the feature, a version of mod_def.mx100 was created with the "outer loop" timesteps:
This mod_def was then used for the cpld_control RTs, but adding the WAV attribute:
All tests passed.
Commit Message
Fix divide-by zero in WW3 appendtail routine.
Add run timers in meshcap
Add over-write capability for mod_def timesteps in meshcap.
Priority
Blocking Dependencies
Git Issues Fixed By This PR
Changes
Subcomponent (with links)
Input data
Regression Tests:
FAILED REGRESSION TESTS
Libraries
Testing Log: