Tendency application update

[grantfirl]

Commit Queue Requirements:

• Fill out all sections of this template.
• All sub component pull requests have been reviewed by their code managers.
• Run the full Intel+GNU RT suite (compared to current baselines) on either Hera/Derecho/Hercules
• Commit 'test_changes.list' from previous step

---

Description:

See https://docs.google.com/presentation/d/1LJbCrCVGYDvm0UPo8SR4KP6fT1VFocg-xLG399qGQ1w/edit?slide=id.g371ddcb3c06_0_238#slide=id.g371ddcb3c06_0_238 for a complete description.

Main points:

• Converts all primary schemes to return tendencies rather than modify the physics state
• Adds code to interstitial schemes to apply tendencies based on control from the host
• Other minor changes (including lots of metadata changes) to implement the above
• Obsolete schemes removed:
  • GFS_MP_generic_pre.F90
  • GFS_DCNV_generic_pre.F90
  • GFS_SCNV_generic_pre.F90
  • GFS_suite_stateout_reset.F90
  • GFS_suite_stateout_update.F90
  • mp_tempo_pre.F90
  • mp_thompson_pre.F90
• New schemes:
  • GFS_photochemistry_post.F90 (because there was no generic interstitial scheme for this to apply tendencies)
  • mynnedmf_wrapper_post.F90 (because it doesn't use GFS_PBL_generic_post.F90)

Commit Message:

* UFSWM - Physics tendency application changes
  * CMEPS - Physics tendency application changes 
  * FV3 - Physics tendency application changes
    * ccpp-physics - Physics tendency application changes

Priority:

• Normal

Git Tracking

UFSWM:

• None

Sub component Pull Requests:

• CMEPS: CCPP metadata changes for feature/tendency_cleanup NOAA-EMC/CMEPS#161
• FV3: Tendency application update NOAA-EMC/ufsatm#989
  • ccpp-physics:Tendency application update ccpp-physics#299

UFSWM Blocking Dependencies:

• None

Documentation:

• No documentation update is required for this PR (please explain).

These changes are transparent for the user. Documentation changes on the CCPP component should be implemented to make sure that schemes follow the precedent set in this PR.

---

Changes

Regression Test Changes (Please commit test_changes.list):

• PR Updates/Changes Baselines.

Input data Changes:

• None.

Library Changes/Upgrades:

• No Updates

---

Testing Log:

• RDHPCS
  • Hera
  • Orion
  • Hercules
  • GaeaC6
  • Derecho
  • Ursa
• WCOSS2
  • Dogwood/Cactus
  • Acorn
• CI
• opnReqTest (complete task if unnecessary)

[gspetro-NOAA]

@grantfirl Are there additional changes expected for this PR (other than conflict resolution), or should we be reviewing it for Commit Queue readiness?

[grantfirl]

@grantfirl Are there additional changes expected for this PR (other than conflict resolution), or should we be reviewing it for Commit Queue readiness?

@gspetro-NOAA EMC wants to wait until after GFSv17 operational implementation to review/merge this, so it won't be ready for the commit queue for a while.

[gspetro-NOAA]

@grantfirl Just checking in--is there a status update on this PR? It's been in draft for a while, so I just wanted to confirm that you're still planning to work on it.

[grantfirl]

@grantfirl Just checking in--is there a status update on this PR? It's been in draft for a while, so I just wanted to confirm that you're still planning to work on it.

Yes, indeed. I've been keeping this branch relatively up-to-date, but there are a few failing RTs that need to be fixed before removing the draft label. Even then, I think that EMC wants to do some more thorough testing to make sure that the result differences are below a threshold before merging.

[gspetro-NOAA]

@grantfirl It looks like this PR includes a CMEPS update, but there is no corresponding CMEPS PR listed. Is this a mistake?

[grantfirl]

@grantfirl It looks like this PR includes a CMEPS update, but there is no corresponding CMEPS PR listed. Is this a mistake?

I forgot to open a PR in CMEPS. There should be one due to CCPP metadata changes needed there.

[grantfirl]

@grantfirl It looks like this PR includes a CMEPS update, but there is no corresponding CMEPS PR listed. Is this a mistake?

I forgot to open a PR in CMEPS. There should be one due to CCPP metadata changes needed there.

@gspetro-NOAA Fixed.

[gspetro-NOAA]

@grantfirl I saw that the CCPP PR has gotten approval from RhaeSung. I imagine you're planning to run the RT suite again, but will this PR likely be ready after that, or is there more work to be done?

[grantfirl]

@grantfirl I saw that the CCPP PR has gotten approval from RhaeSung. I imagine you're planning to run the RT suite again, but will this PR likely be ready after that, or is there more work to be done?

Yes, I'm going to run the RT suite again on Ursa. If successful, then it should be ready! I'm just doing final changes to update to the latest develop branches before kicking off RTs.

[grantfirl]

@gspetro-NOAA @rhaesung I re-ran RTs on ursa and the results look to be the same, so I think that this is ready.

@gspetro-NOAA All tests using the RAS convection scheme fail to run, but this is expected. I have orders to remove this scheme from CCPP in a followup PR, so should we remove RAS tests from rt.conf in this PR, knowing that they fail, but it is of no consequence?

[gspetro-NOAA]

@gspetro-NOAA @rhaesung I re-ran RTs on ursa and the results look to be the same, so I think that this is ready.

@gspetro-NOAA All tests using the RAS convection scheme fail to run, but this is expected. I have orders to remove this scheme from CCPP in a followup PR, so should we remove RAS tests from rt.conf in this PR, knowing that they fail, but it is of no consequence?

I think it's best to remove those tests as part of this PR, and @dpsarmie agrees. It will mess up RT testing if we have a handful of tests that are failing but are supposed to fail (easy to miss others that are failing but not supposed to fail). Have project leads for those tests been notified? Just want to be sure it doesn't take anyone by surprise, but it sounds like there were already plans to remove them. @BrianCurtis-NOAA @NickSzapiro-NOAA Let us know if you have different thoughts on the matter.