Skip to content

Fix UFSATM CI github action#3035

Closed
DusanJovic-NOAA wants to merge 4 commits intoufs-community:developfrom
DusanJovic-NOAA:test_ufsatm_ci
Closed

Fix UFSATM CI github action#3035
DusanJovic-NOAA wants to merge 4 commits intoufs-community:developfrom
DusanJovic-NOAA:test_ufsatm_ci

Conversation

@DusanJovic-NOAA
Copy link
Copy Markdown
Collaborator

@DusanJovic-NOAA DusanJovic-NOAA commented Dec 26, 2025

Commit Queue Requirements:

  • This PR addresses a relevant WM issue (if not, create an issue).
  • All subcomponent pull requests (if any) have been reviewed by their code managers.
  • Run the full Intel+GNU RT suite (compared to current baselines), preferably on Ursa (Derecho or Hercules are acceptable alternatives). Exceptions: documentation-only PRs, CI-only PRs, etc.
    • Commit log file w/full results from RT suite run (if applicable).
    • Verify that test_changes.list indicates which tests, if any, are changed by this PR. Commit test_changes.list, even if it is empty.
  • Fill out all sections of this template.

Description:

Update the UFSATM GitHub CI action to fix the failing spack stack build. See NOAA-EMC/ufsatm#1045

Commit Message:

* UFSWM - Update the UFSATM GitHub CI action
  * UFSATM - Update GitHub CI action

Priority:

  • Critical Bugfix: Reason
  • High: Reason
  • Normal

Git Tracking

UFSWM:

Sub component Pull Requests:

UFSWM Blocking Dependencies:

  • Blocked by #
  • None

Documentation:

  • Documentation update required.
    • Relevant updates are included with this PR.
    • A WM issue has been opened to track the need for a documentation update; a person responsible for submitting the update has been assigned to the issue (link issue).
  • Documentation update NOT required.
    • Explanation:

Changes

Regression Test Changes (Please commit test_changes.list):

  • PR Adds New Tests/Baselines.
  • PR Updates/Changes Baselines.
  • No Baseline Changes.

Input data Changes:

  • None.
  • PR adds input data.
  • PR changes existing input data.

Library Changes/Upgrades:

  • Required
    • Library names w/versions:
    • Git Stack Issue (JCSDA/spack-stack#)
  • No Updates

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • GaeaC6
    • Derecho
    • Ursa
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
  • opnReqTest (complete task if unnecessary)

@github-project-automation github-project-automation bot moved this to Evaluating in PRs to Process Dec 26, 2025
@gspetro-NOAA gspetro-NOAA added No Baseline Change No Baseline Change UFSATM There are changes to the UFSATM repository. labels Dec 30, 2025
@gspetro-NOAA
Copy link
Copy Markdown
Collaborator

gspetro-NOAA commented Dec 30, 2025

@DusanJovic-NOAA Is this PR ready to go? I see it's addressing the UFSATM CI, so I'm presuming that's why there are no logs uploaded? Just want to confirm in case anything remains to be done.

@DusanJovic-NOAA
Copy link
Copy Markdown
Collaborator Author

DusanJovic-NOAA commented Dec 30, 2025

@DusanJovic-NOAA Is this PR ready to go? I see it's addressing the UFSATM CI, so I'm presuming that's why there are no logs uploaded? Just want to confirm in case anything remains to be done.

Yes, it's ready. No baseline changes expected. It can be combined with some other PR.

@gspetro-NOAA gspetro-NOAA moved this from Evaluating to Review in PRs to Process Dec 30, 2025
@gspetro-NOAA gspetro-NOAA moved this from Review to Schedule in PRs to Process Jan 5, 2026
@gspetro-NOAA
Copy link
Copy Markdown
Collaborator

gspetro-NOAA commented Jan 5, 2026 •
edited
Loading

@DusanJovic-NOAA I think we will try to combine this with #3033 and process it today. Could you sync w/develop?

@gspetro-NOAA gspetro-NOAA mentioned this pull request Jan 5, 2026
Closed
22 tasks
@DusanJovic-NOAA
Copy link
Copy Markdown
Collaborator Author

DusanJovic-NOAA commented Jan 5, 2026

@DusanJovic-NOAA I think we will try to combine this with #3033 and process it today. Could you sync w/develop?

Done.

@FernandoAndrade-NOAA FernandoAndrade-NOAA mentioned this pull request Jan 7, 2026
Merged
14 tasks
@FernandoAndrade-NOAA
Copy link
Copy Markdown
Collaborator

FernandoAndrade-NOAA commented Jan 7, 2026 •
edited
Loading

Note: We will be including this PR within #2863 instead as #3033 is on hold.

FernandoAndrade-NOAA pushed a commit that referenced this pull request Jan 9, 2026
@natalie-perlin
Derecho updates: new spack-stack-1.9.2, rocoto, ecflow paths, TPN=128…
ac8ae82 
… default + Fix UFSATM CI github action #3035 (#2863)

* Derecho update of rocoto and ecflow paths

* Derecho rt_utils.sh: wait longer to query completed job status

* use new Derecho spack-stack 1.9.2 environment built with ncarenv/24.12

* updates of modulefile and compile_qsub for derecho

* update a script fv3_qsub.IN_derecho

* updates for derecho RTs

* tests configurations updated for derecho

* updated module-setup.sh for Derecho and ufs_derecho.intel.lua modulefile

* turn off derecho failed cases

* Fix for derecho: use nccmp/1.9.0.1 module from spack-stack

* Fix for modulefiles/ufs_derecho.gnu.lua: add env. compiler variables

* Enable GNU tests on Derecho

* combine in pr3035 ufsatm ci fix
@jkbk2004
Copy link
Copy Markdown
Collaborator

jkbk2004 commented Jan 9, 2026

merged with #2863

@jkbk2004 jkbk2004 closed this Jan 9, 2026
@gspetro-NOAA gspetro-NOAA mentioned this pull request Mar 2, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

No Baseline Change No Baseline Change UFSATM There are changes to the UFSATM repository.

Projects

PRs to Process
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

UFASTM CI GitHub action needs to be updated

4 participants

@DusanJovic-NOAA @gspetro-NOAA @FernandoAndrade-NOAA @jkbk2004