Skip to content

Remove goto statements in WW3 subcomponent#3040

Merged
gspetro-NOAA merged 12 commits intoufs-community:developfrom
mingchen-NOAA:rmGoTosinWW3
Jan 12, 2026
Merged

Remove goto statements in WW3 subcomponent#3040
gspetro-NOAA merged 12 commits intoufs-community:developfrom
mingchen-NOAA:rmGoTosinWW3

Conversation

@mingchen-NOAA
Copy link
Copy Markdown
Collaborator

@mingchen-NOAA mingchen-NOAA commented Jan 2, 2026

Commit Queue Requirements:

  • This PR addresses a relevant WM issue (if not, create an issue).
  • All subcomponent pull requests (if any) have been reviewed by their code managers.
  • Run the full Intel+GNU RT suite (compared to current baselines), preferably on Ursa (Derecho or Hercules are acceptable alternatives). Exceptions: documentation-only PRs, CI-only PRs, etc.
    • Commit log file w/full results from RT suite run (if applicable).
    • Verify that test_changes.list indicates which tests, if any, are changed by this PR. Commit test_changes.list, even if it is empty.
  • Fill out all sections of this template.

Description:

This PR removes remaining GOTO statements in WW3 subcomponent.

Commit Message:

* UFSWM - Remove goto statements
  * WW3 - Remove goto statements in wav_shel_in.F90

Priority:

  • Critical Bugfix: Reason
  • High: Reason
  • Normal

Git Tracking

UFSWM:

Sub component Pull Requests:

UFSWM Blocking Dependencies:

  • Blocked by #
  • None

Documentation:

  • Documentation update required.
    • Relevant updates are included with this PR.
    • A WM issue has been opened to track the need for a documentation update; a person responsible for submitting the update has been assigned to the issue (link issue).
  • Documentation update NOT required.
    • Explanation:

Changes

Regression Test Changes (Please commit test_changes.list):

  • PR Adds New Tests/Baselines.
  • PR Updates/Changes Baselines.
  • No Baseline Changes.

Input data Changes:

  • None.
  • PR adds input data.
  • PR changes existing input data.

Library Changes/Upgrades:

  • Required
    • Library names w/versions:
    • Git Stack Issue (JCSDA/spack-stack#)
  • No Updates

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • GaeaC6
    • Derecho
    • Ursa
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
  • opnReqTest (complete task if unnecessary)

@github-project-automation github-project-automation bot moved this to Evaluating in PRs to Process Jan 2, 2026
@gspetro-NOAA gspetro-NOAA added No Baseline Change No Baseline Change WW3 There are changes to the WW3 component repository. labels Jan 5, 2026
@gspetro-NOAA
Copy link
Copy Markdown
Collaborator

@mingchen-NOAA Your PR says it's non-baseline-changing, but you haven't pushed the empty test_changes.list file from your Ursa run. Could you do that?

@mingchen-NOAA
Copy link
Copy Markdown
Collaborator Author

@gspetro-NOAA I know my test_changes.list is clean. I think it messed up when I update to develop.

@gspetro-NOAA gspetro-NOAA moved this from Evaluating to Review in PRs to Process Jan 5, 2026
@mingchen-NOAA
Copy link
Copy Markdown
Collaborator Author

@gspetro-NOAA reran the full RT and uploaded the logs.

@gspetro-NOAA gspetro-NOAA moved this from Done to Evaluating in PRs to Process Jan 6, 2026
@gspetro-NOAA gspetro-NOAA moved this from Evaluating to Review in PRs to Process Jan 8, 2026
@gspetro-NOAA gspetro-NOAA moved this from Review to Schedule in PRs to Process Jan 8, 2026
@FernandoAndrade-NOAA
Copy link
Copy Markdown
Collaborator

This PR is next in queue, please go ahead and resync and resolve conflicts. Thank you.

@mingchen-NOAA
Copy link
Copy Markdown
Collaborator Author

@FernandoAndrade-NOAA Done! Thank you!

@FernandoAndrade-NOAA FernandoAndrade-NOAA added jenkins-ort run ORT testing In Testing The PR that is currently in testing stages labels Jan 9, 2026
 on-behalf-of @ufs-community <ecc.platform@noaa.gov>
@epic-cicd-jenkins epic-cicd-jenkins removed the jenkins-ort run ORT testing label Jan 9, 2026
@JessicaMeixner-NOAA
Copy link
Copy Markdown
Collaborator

WW3 is merged: NOAA-EMC/WW3@ae1db52

@gspetro-NOAA
Copy link
Copy Markdown
Collaborator

@mingchen-NOAA Could you revert .gitmodules and update the WW3 hash?

@mingchen-NOAA
Copy link
Copy Markdown
Collaborator Author

@mingchen-NOAA Could you revert .gitmodules and update the WW3 hash?

@gspetro-NOAA done

@gspetro-NOAA gspetro-NOAA merged commit 06eebdb into ufs-community:develop Jan 12, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

No Baseline Change No Baseline Change WW3 There are changes to the WW3 component repository.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

GOTO statements in WW3 subcomponent

7 participants