Skip to content

Fix Issue #2119 - shrink regional domain slightly#3047

Merged
gspetro-NOAA merged 15 commits intoufs-community:developfrom
gspetro-NOAA:fix/wm-issue-2119
Jan 24, 2026
Merged

Fix Issue #2119 - shrink regional domain slightly#3047
gspetro-NOAA merged 15 commits intoufs-community:developfrom
gspetro-NOAA:fix/wm-issue-2119

Conversation

@gspetro-NOAA
Copy link
Copy Markdown
Collaborator

@gspetro-NOAA gspetro-NOAA commented Jan 13, 2026

Commit Queue Requirements:

  • This PR addresses a relevant WM issue (if not, create an issue).
  • All subcomponent pull requests (if any) have been reviewed by their code managers. (N/A)
  • Run the full Intel+GNU RT suite (compared to current baselines), preferably on Ursa (Derecho or Hercules are acceptable alternatives). Exceptions: documentation-only PRs, CI-only PRs, etc.
    • Commit log file w/full results from RT suite run (if applicable).
    • Verify that test_changes.list indicates which tests, if any, are changed by this PR. Commit test_changes.list, even if it is empty.
  • Fill out all sections of this template.

Description:

This PR implements the fix proposed in Issue #2119 for missing values of dyn/phy output in regional regression tests on west and south boundaries.
It also modifies rt.conf to run gnv1_nested_intel on WCOSS2 and Hercules.

Commit Message:

* UFSWM - shrink domain slightly for regional tests; activate gnv1_nested_intel on wcoss2/hercules

Priority:

  • Critical Bugfix: Reason
  • High: Reason
  • Normal

Git Tracking

UFSWM:

Sub component Pull Requests:

  • None

UFSWM Blocking Dependencies:

  • Blocked by #
  • None

Documentation:

  • Documentation update required.
    • Relevant updates are included with this PR.
    • A WM issue has been opened to track the need for a documentation update; a person responsible for submitting the update has been assigned to the issue (link issue).
  • Documentation update NOT required.
    • Explanation: Fix does not affect documented capabilities

Changes

Regression Test Changes (Please commit test_changes.list):

  • PR Adds New Tests/Baselines.
  • PR Updates/Changes Baselines.
  • No Baseline Changes.

Input data Changes:

  • None.
  • PR adds input data.
  • PR changes existing input data.

Library Changes/Upgrades:

  • Required
    • Library names w/versions:
    • Git Stack Issue (JCSDA/spack-stack#)
  • No Updates

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • GaeaC6
    • Derecho
    • Ursa
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
  • opnReqTest (complete task if unnecessary)

@github-project-automation github-project-automation bot moved this to Evaluating in PRs to Process Jan 13, 2026
@gspetro-NOAA gspetro-NOAA added the Baseline Updates Current baselines will be updated. label Jan 13, 2026
@gspetro-NOAA gspetro-NOAA marked this pull request as ready for review January 13, 2026 19:31
@gspetro-NOAA gspetro-NOAA moved this from Evaluating to Review in PRs to Process Jan 13, 2026
@gspetro-NOAA gspetro-NOAA added the Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked. label Jan 22, 2026
@gspetro-NOAA gspetro-NOAA added the In Testing The PR that is currently in testing stages label Jan 22, 2026
@gspetro-NOAA
Copy link
Copy Markdown
Collaborator Author

gspetro-NOAA commented Jan 22, 2026

gnv1_nested_intel failed this time on Hercules, so I'm wondering if the intermittent failures are still present... 🤔 I'll see what it does the second time. @BrianCurtis-NOAA if things fail on WCOSS2, we can just revert the changes to rt.conf and proceed with the rest of the PR.
UPDATE: I forgot to create a new baseline for it, so no wonder it failed. 🤦‍♀️

@BrianCurtis-NOAA
Copy link
Copy Markdown
Collaborator

gnv1_nested_intel failed this time on Hercules, so I'm wondering if the intermittent failures are still present... 🤔 I'll see what it does the second time. @BrianCurtis-NOAA if things fail on WCOSS2, we can just revert the changes to rt.conf and proceed with the rest of the PR. UPDATE: I forgot to create a new baseline for it, so no wonder it failed. 🤦‍♀️

Great, but we don't need to add it to test_changes.list because it will still work without bl change on the platforms that run it still, correct?

@gspetro-NOAA
Copy link
Copy Markdown
Collaborator Author

gspetro-NOAA commented Jan 22, 2026

@BrianCurtis-NOAA Yes, it should work on platforms that run it already, but since Hercules & WCOSS2 will both require new baselines, it seems to me like it should still go in test_changes.list. If we run ./rt.sh -a <account> -c -b test_changes.list -e without it, it'll fail on WCOSS2 & Hercules and require the addition of that test manually to the file. Or is that preferred to know for certain that running that command didn't lead to unexpected baseline changes on platforms that were already running the test?

@FernandoAndrade-NOAA FernandoAndrade-NOAA added the jenkins-ort run ORT testing label Jan 22, 2026
@epic-cicd-jenkins epic-cicd-jenkins removed the jenkins-ort run ORT testing label Jan 22, 2026
@gspetro-NOAA gspetro-NOAA added the jenkins-ort run ORT testing label Jan 22, 2026
@epic-cicd-jenkins epic-cicd-jenkins removed the jenkins-ort run ORT testing label Jan 23, 2026
@FernandoAndrade-NOAA FernandoAndrade-NOAA added the jenkins-ort run ORT testing label Jan 23, 2026
 on-behalf-of @ufs-community <ecc.platform@noaa.gov>
@epic-cicd-jenkins epic-cicd-jenkins removed the jenkins-ort run ORT testing label Jan 23, 2026
@gspetro-NOAA gspetro-NOAA removed the In Testing The PR that is currently in testing stages label Jan 23, 2026
@gspetro-NOAA gspetro-NOAA merged commit bd72fd4 into ufs-community:develop Jan 24, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Baseline Updates Current baselines will be updated. Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked.

Projects

Archived in project

6 participants