Skip to content

update MOM6 to its main repo. 20260112 updating#3051

Merged
FernandoAndrade-NOAA merged 18 commits intoufs-community:developfrom
jiandewang:feature/update-MOM6-20260112
Jan 28, 2026
Merged

update MOM6 to its main repo. 20260112 updating#3051
FernandoAndrade-NOAA merged 18 commits intoufs-community:developfrom
jiandewang:feature/update-MOM6-20260112

Conversation

@jiandewang
Copy link
Copy Markdown
Collaborator

@jiandewang jiandewang commented Jan 14, 2026

Commit Queue Requirements:

  • This PR addresses a relevant WM issue (if not, create an issue).
  • All subcomponent pull requests (if any) have been reviewed by their code managers.
  • Run the full Intel+GNU RT suite (compared to current baselines), preferably on Ursa (Derecho or Hercules are acceptable alternatives). Exceptions: documentation-only PRs, CI-only PRs, etc.
    • Commit log file w/full results from RT suite run (if applicable).
    • Verify that test_changes.list indicates which tests, if any, are changed by this PR. Commit test_changes.list, even if it is empty.
  • Fill out all sections of this template.

Description:

MOM6 main repo. was updated on 20260112 which is originally GFDL's 20250925 PR. See detail at mom-ocean/MOM6#1680. We need to sync dev/emc repo correspongingly.

Note in this PR an OBC bug fixing flag is introduced which will change answer. To retain BL for current OBC setting job, we can add OBC_PROJECTION_BUG=T. But we are going to use its defaule value False in UWM which means we will need a new BL for hafs_regional_storm_following_1nest_atm_ocn_wav_mom6.

Commit Message:

* UFSWM - 
  * AQM - 
  * CDEPS - 
  * CICE - 
  * CMEPS - 
  * CMakeModules - 
  * UFSATM - 
    * ccpp-physics - 
    * atmos_cubed_sphere - 
  * GOCART - 
  * HYCOM - 
  * MOM6 - update MOM6 to its main repository 20260112 updating (originally GFDL's 20250925 PR)
  * NOAHMP - 
  * WW3 - 
  * fire_behavior
  * stochastic_physics - 

Priority:

  • Critical Bugfix: Reason
  • High: Reason
  • Normal

Git Tracking

UFSWM:

Sub component Pull Requests:

UFSWM Blocking Dependencies:

  • Blocked by #
  • None

Documentation:

  • Documentation update required.
    • Relevant updates are included with this PR.
    • A WM issue has been opened to track the need for a documentation update; a person responsible for submitting the update has been assigned to the issue (link issue).
  • Documentation update NOT required.
    • Explanation:

Changes

Regression Test Changes (Please commit test_changes.list):

  • PR Adds New Tests/Baselines.
  • PR Updates/Changes Baselines.
  • No Baseline Changes.

Input data Changes:

  • None.
  • PR adds input data.
  • PR changes existing input data.

Library Changes/Upgrades:

  • Required
    • Library names w/versions:
    • Git Stack Issue (JCSDA/spack-stack#)
  • No Updates

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • GaeaC6
    • Derecho
    • Ursa
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
  • opnReqTest (complete task if unnecessary)

@jiandewang
Copy link
Copy Markdown
Collaborator Author

this PR has been fully tested on wcoss2, URSA, GAEA C6 and URSA and can be put in commit queue

@gspetro-NOAA gspetro-NOAA added Baseline Updates Current baselines will be updated. MOM There are changes to the MOM6 component repository. labels Jan 15, 2026
@gspetro-NOAA gspetro-NOAA moved this from Evaluating to Pre-testing required in PRs to Process Jan 15, 2026
@gspetro-NOAA
Copy link
Copy Markdown
Collaborator

@jiandewang Could you push the logs from a full RT run, preferably on Ursa (Hercules would also be fine)?

@jiandewang
Copy link
Copy Markdown
Collaborator Author

@jiandewang Could you push the logs from a full RT run, preferably on Ursa (Hercules would also be fine)?

@gspetro-NOAA just added hercules run log.

@gspetro-NOAA
Copy link
Copy Markdown
Collaborator

gspetro-NOAA commented Jan 15, 2026

@gspetro-NOAA just added hercules run log.

Thanks! And just to confirm, only one RT changes baselines?

EDIT: Nvm, I can see from the logs that only one RT changes BL. :)

@gspetro-NOAA gspetro-NOAA moved this from Pre-testing required to Waiting for Reviews (subcomponent) in PRs to Process Jan 15, 2026
@jiandewang
Copy link
Copy Markdown
Collaborator Author

yes, only hafs_regional_storm_following_1nest_atm_ocn_wav_mom6 needs a new BL

@jiandewang
Copy link
Copy Markdown
Collaborator Author

@gspetro-NOAA FYI: submodule MOM6 has been reviewed and approved.

@gspetro-NOAA gspetro-NOAA moved this from Waiting for Reviews (subcomponent) to Review in PRs to Process Jan 20, 2026
@gspetro-NOAA gspetro-NOAA moved this from Review to Schedule in PRs to Process Jan 21, 2026
@gspetro-NOAA
Copy link
Copy Markdown
Collaborator

@jiandewang Please sync with develop as soon as you have a chance. We'd like to process this PR next.

@jiandewang
Copy link
Copy Markdown
Collaborator Author

@gspetro-NOAA I am not in front of computer at this moment, will sync it once I am back home. Thanks

@gspetro-NOAA
Copy link
Copy Markdown
Collaborator

@gspetro-NOAA I am not in front of computer at this moment, will sync it once I am back home. Thanks

No worries--it's the weekend! I probably should have left off my usual "as soon as you can." 😉

@jiandewang
Copy link
Copy Markdown
Collaborator Author

@gspetro-NOAA I just did sync but seems not totally correct. THese are my steps (I can't do on github web as there are conflict for change-list.txt and hercules log file).

(1) git clone https://github.com/jiandewang/ufs-weather-model
(2) cd ufs-weather-model
(3) git checkout feature/update-MOM6-20260112
(4) git submodule update --init --recursive
(5) git remote add upstream https://github.com/ufs-community/ufs-weather-model
(6) git fetch upstream
(7) git merge origin feature/update-MOM6-20260112

then it shows two files are in conflict, I used
git checkout --ours tests/logs/RegressionTests_hercules.log
git checkout --ours tests/test_changes.list
git add *
git commit -m '.....'
git push origin feature/update-MOM6-20260112

apparently the above steps are not totally correct as I can see from https://github.com/ufs-community/ufs-weather-model/pull/3051/files.

This PR should only has changes in MOM6 and mom6_files.cmake

What's the step that I missed ?

@jiandewang
Copy link
Copy Markdown
Collaborator Author

@gspetro-NOAA I know the reason now, I forgot to do submodule update after the merging. Fixed it.

@FernandoAndrade-NOAA FernandoAndrade-NOAA added Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked. jenkins-ort run ORT testing In Testing The PR that is currently in testing stages labels Jan 26, 2026
 on-behalf-of @ufs-community <ecc.platform@noaa.gov>
@epic-cicd-jenkins epic-cicd-jenkins removed the jenkins-ort run ORT testing label Jan 26, 2026
@FernandoAndrade-NOAA
Copy link
Copy Markdown
Collaborator

We should be all set with testing, leaving a note in sub PR.

@jiandewang
Copy link
Copy Markdown
Collaborator Author

MOM6 merged, hash is b4d9a232

@jiandewang
Copy link
Copy Markdown
Collaborator Author

is it the time for mt to do the submodule updating ?

@FernandoAndrade-NOAA
Copy link
Copy Markdown
Collaborator

is it the time for mt to do the submodule updating ?

Yes, please go ahead and resync and revert .gitmodules, thank you.

@jiandewang
Copy link
Copy Markdown
Collaborator Author

MOM6 submodule reverted

@FernandoAndrade-NOAA FernandoAndrade-NOAA merged commit 6249016 into ufs-community:develop Jan 28, 2026
9 checks passed
@github-project-automation github-project-automation bot moved this from Schedule to Done in PRs to Process Jan 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Baseline Updates Current baselines will be updated. In Testing The PR that is currently in testing stages MOM There are changes to the MOM6 component repository. Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

update MOM6 to its main repo. 20260112 updating

6 participants