[production/GFS.v17] Add UFSATM prodv17 submodule

[dpsarmie]

Commit Queue Requirements:

• This PR addresses a relevant WM issue (if not, create an issue).
• All subcomponent pull requests (if any) have been reviewed by their code managers.
• Run the full Intel+GNU RT suite (compared to current baselines), preferably on Ursa (Derecho or Hercules are acceptable alternatives). Exceptions: documentation-only PRs, CI-only PRs, etc.
  • Commit log file w/full results from RT suite run (if applicable).
  • Verify that test_changes.list indicates which tests, if any, are changed by this PR. Commit test_changes.list, even if it is empty.
• Fill out all sections of this template.

---

Description:

Add submodule pointer to UFSATM production branch. The production branch should be https://github.com/NOAA-EMC/ufsatm/tree/b4d035bfdee784786cd19b50deab3e3e0a273f1c + removal of extra fields in cpl/module_cplfields.F90 (NOAA-EMC/ufsatm#1048) + a GWD fix that will be coming into develop (ufs-community/ccpp-physics#347)

Commit Message:

* UFSWM - Modifies .gitmodules to point to UFSATM production/GFS.v17 branch
  * UFSATM - Removes unused fields; prod branched off of UFSATM/b4d035b
  * ccpp-physics - Add hotfix for gravity wave drag

Priority:

• Normal

Git Tracking

UFSWM:

• No issue needed for production branch update

Sub component Pull Requests:

• [production/GFS.v17] Remove unused fields NOAA-EMC/ufsatm#1048
• [production/GFS.v17] Add CCPP Physics production branch NOAA-EMC/ufsatm#1054
• Modified 'dtfac' OGWD tendency limiter in drag_suite_psl to match tha… ccpp-physics#347

UFSWM Blocking Dependencies:

• None

Documentation:

• Documentation update NOT required.
  • Explanation: Just adding modifications to the GFSv17 production branch

---

• No Baseline Changes.

Input data Changes:

• None.

Library Changes/Upgrades:

• No Updates

---

Testing Log:

• RDHPCS
  • Hera
  • Orion
  • Hercules
  • GaeaC6
  • Derecho
  • Ursa
• WCOSS2
  • Dogwood/Cactus
  • Acorn
• CI
• opnReqTest (complete task if unnecessary)

[dpsarmie]

@gspetro-NOAA We should talk at the CM meeting today about how you all want to handle these PRs that modify the production branch. (expectations, tests needed, etc.)

[gspetro-NOAA]

@dpsarmie I will leave you to adjust statuses on the production branch PRs, since you're more likely than I to know where they stand.

[dpsarmie]

@gspetro-NOAA I finished testing and this can get merged into the production/GFS.v17 branch.

[gspetro-NOAA]

@dpsarmie Fine by me! You said this one will not have a corresponding develop branch PR, right?

[dpsarmie]

Correct. I'll tag develop PRs to the corresponding prod PRs just so we have some documentation.

[dpsarmie]

This is ready to get merged into the production/GFS.v17 branch. I tested on my end via regression tests and everything looked good.

Once this is merged, the GFSv17 retro runs will continue.

[JessicaMeixner-NOAA]

Thanks @dpsarmie !

[NickSzapiro-NOAA]

Is there a UFSATM sub-component PR @dpsarmie ?

[NickSzapiro-NOAA]

Oh, I see it now. Can you fill out the template?

[dpsarmie]

Is there a UFSATM sub-component PR @dpsarmie ?

Yes but all subcomponents were already tested and merged into their respective production branches:
UFSATM:
NOAA-EMC/ufsatm#1048
NOAA-EMC/ufsatm#1054

CCPP Physics:
ufs-community/ccpp-physics#347

It's just that the UFSWM has the 2 reviewer restriction before merging, so I didn't want to circumvent that to hit the merge button on these prod-only PRs.

[dpsarmie]

Ok, added the info to the template.

[NickSzapiro-NOAA]

Thanks! Maybe checkbox which machines were tested