Skip to content

[production/RRFS.v1] Umbrella for RRFS code speedups (in ccpp-physics and stochastic_physics)#3061

Merged
MatthewPyle-NOAA merged 17 commits intoufs-community:production/RRFS.v1from
MatthewPyle-NOAA:feature/rucspeedupredo
Mar 11, 2026
Merged

[production/RRFS.v1] Umbrella for RRFS code speedups (in ccpp-physics and stochastic_physics)#3061
MatthewPyle-NOAA merged 17 commits intoufs-community:production/RRFS.v1from
MatthewPyle-NOAA:feature/rucspeedupredo

Conversation

@MatthewPyle-NOAA
Copy link
Copy Markdown
Collaborator

@MatthewPyle-NOAA MatthewPyle-NOAA commented Jan 21, 2026

Commit Queue Requirements:

  • This PR addresses a relevant WM issue (if not, create an issue). (Placeholder issue seeking guidance for optimizing model run time on WCOSS2 for RRFS application #3023)
  • All subcomponent pull requests (if any) have been reviewed by their code managers.
  • Run the full Intel+GNU RT suite (compared to current baselines), preferably on Ursa (Derecho or Hercules are acceptable alternatives). Exceptions: documentation-only PRs, CI-only PRs, etc.
    • Commit log file w/full results from RT suite run (if applicable).
    • Verify that test_changes.list indicates which tests, if any, are changed by this PR. Commit test_changes.list, even if it is empty.
  • Fill out all sections of this template.

Description:

This PR brings in some needed code speedups for the RRFS system.

  1. a ccpp-physics change that speeds up the RUC LSM
  2. a stochastic-physics change that limits soil T/q perturbations to initial time, and adds some OMP directives to enhance performance on multiple threads.

Commit Message:

* UFSWM - 
  * stochastic-physics: https://github.com/NOAA-PSL/stochastic_physics/pull/95
  * UFSATM - https://github.com/NOAA-EMC/ufsatm/pull/1057
    * ccpp-physics - https://github.com/ufs-community/ccpp-physics/pull/351
 

Priority:

  • Critical Bugfix: Reason
  • High: Trying to get this code optimization incorporated into the pre-implementation RRFS parallel as quickly as possible.
  • Normal

Git Tracking

UFSWM:

  • Closes #

Sub component Pull Requests:

UFSWM Blocking Dependencies:

  • Blocked by #
  • None

Documentation:

  • Documentation update required.
    • Relevant updates are included with this PR.
    • A WM issue has been opened to track the need for a documentation update; a person responsible for submitting the update has been assigned to the issue (link issue).
  • Documentation update NOT required.
    • Explanation:

Changes

Regression Test Changes (Please commit test_changes.list):

  • PR Adds New Tests/Baselines.
  • PR Updates/Changes Baselines.
  • No Baseline Changes.

Input data Changes:

  • None.
  • PR adds input data.
  • PR changes existing input data.

Library Changes/Upgrades:

  • Required
    • Library names w/versions:
    • Git Stack Issue (JCSDA/spack-stack#)
  • No Updates

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • GaeaC6
    • Derecho
    • Ursa
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
  • opnReqTest (complete task if unnecessary)

@github-project-automation github-project-automation bot moved this to Evaluating in PRs to Process Jan 21, 2026
@MatthewPyle-NOAA MatthewPyle-NOAA changed the title [production/RRFS.v1] Umbrella for RUC LSM speedup change in CCPP [production/RRFS.v1] Umbrella for code speedups (in ccpp-physics and stochastic_physics) Jan 22, 2026
@MatthewPyle-NOAA MatthewPyle-NOAA changed the title [production/RRFS.v1] Umbrella for code speedups (in ccpp-physics and stochastic_physics) [production/RRFS.v1] Umbrella for RRFS code speedups (in ccpp-physics and stochastic_physics) Jan 22, 2026
@MatthewPyle-NOAA
Copy link
Copy Markdown
Collaborator Author

CCPP-physics change has been merged now.

@gspetro-NOAA gspetro-NOAA added Priority: High UFSATM There are changes to the UFSATM repository. CCPP There are changes to a CCPP repository. SP There are changes to the stochastic_physics component repository. labels Feb 2, 2026
@jkbk2004
Copy link
Copy Markdown
Collaborator

@MatthewPyle-NOAA new hash for stochastic physics rrfsv1 branch is NOAA-PSL/stochastic_physics@b8eda18

@jkbk2004
Copy link
Copy Markdown
Collaborator

@MatthewPyle-NOAA still in draft mode?

@MatthewPyle-NOAA MatthewPyle-NOAA marked this pull request as ready for review February 20, 2026 15:27
@MatthewPyle-NOAA
Copy link
Copy Markdown
Collaborator Author

Was just about to change it, @jkbk2004

@MatthewPyle-NOAA MatthewPyle-NOAA marked this pull request as draft February 27, 2026 17:33
@MatthewPyle-NOAA
Copy link
Copy Markdown
Collaborator Author

Reverted it to a draft, as planning to include one more ccpp-physics change with this umbrella change.

@MatthewPyle-NOAA
Copy link
Copy Markdown
Collaborator Author

@jkbk2004 I've put updated answers for two tests (control_lndp_debug_intel and rap_lndp_debug_intel) onto Hera/Ursa under /scratch4/NCEPDEV/fv3-cam/Matthew.Pyle/rrfs_baseline_updates/ On WCOSS these now are under a 20260227 baseline date.

@MatthewPyle-NOAA MatthewPyle-NOAA marked this pull request as ready for review February 27, 2026 20:17
@MatthewPyle-NOAA
Copy link
Copy Markdown
Collaborator Author

@jkbk2004 We were thinking of adding another bug fix to this umbrella PR. The change is in atmos_cubed_sphere. But if you feel like this one is too far along, we can handle it with a follow on PR.

@jkbk2004
Copy link
Copy Markdown
Collaborator

jkbk2004 commented Mar 4, 2026

@MatthewPyle-NOAA Yeah, incremental update will be easier.

@MatthewPyle-NOAA
Copy link
Copy Markdown
Collaborator Author

@jkbk2004 Okay, should be back to what you tested on Hercules now.

@jkbk2004
Copy link
Copy Markdown
Collaborator

jkbk2004 commented Mar 4, 2026

@MatthewPyle-NOAA just note that .gitmodules points to the fv3 feature branch. I am ok if you want to go ahead to merge after revert change in gitmodules.

@MatthewPyle-NOAA
Copy link
Copy Markdown
Collaborator Author

@jkbk2004 Just merged the UFSATM PR - will update things a bit later (have some meetings soon).

@MatthewPyle-NOAA
Copy link
Copy Markdown
Collaborator Author

@jkbk2004 What do I need to do to move this one along? Not sure whose approval I need. Thanks!

@jkbk2004
Copy link
Copy Markdown
Collaborator

@jkbk2004 What do I need to do to move this one along? Not sure whose approval I need. Thanks!

@MatthewPyle-NOAA you can go ahead to merge.

@MatthewPyle-NOAA
Copy link
Copy Markdown
Collaborator Author

@jkbk2004 I see a "Merging is blocked" since 2 approving reviews are required.

@BrianCurtis-NOAA
Copy link
Copy Markdown
Collaborator

Everything seems to point to where it needs to. Approved.

@MatthewPyle-NOAA MatthewPyle-NOAA merged commit 58f3afe into ufs-community:production/RRFS.v1 Mar 11, 2026
1 check passed
@MatthewPyle-NOAA MatthewPyle-NOAA deleted the feature/rucspeedupredo branch March 11, 2026 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CCPP There are changes to a CCPP repository. Priority: High SP There are changes to the stochastic_physics component repository. UFSATM There are changes to the UFSATM repository.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants