Modified 'dtfac' OGWD tendency limiter in drag_suite_psl to match that in drag_suite_run

[XiaqiongZhou-NOAA]

Commit Queue Requirements:

• This PR addresses a relevant WM issue (if not, create an issue).
• All subcomponent pull requests (if any) have been reviewed by their code managers.
• Run the full Intel+GNU RT suite (compared to current baselines), preferably on Ursa (Derecho or Hercules are acceptable alternatives). Exceptions: documentation-only PRs, CI-only PRs, etc.
  • Commit log file w/full results from RT suite run (if applicable).
  • Verify that test_changes.list indicates which tests, if any, are changed by this PR. Commit test_changes.list, even if it is empty.
• Fill out all sections of this template.

---

Description:

Update ccpp_physics to
modify 'dtfac' OGWD tendency limiter in drag_suite_psl to match that in drag_suite_run.

Commit Message:

* UFSWM - modify 'dtfac' OGWD tendency limiter in drag_suite_psl to match that in drag_suite_run.
    * UFSATM - modify 'dtfac' OGWD tendency limiter in drag_suite_psl to match that in drag_suite_run.
        * ccpp-physics - modify 'dtfac' OGWD tendency limiter in drag_suite_psl to match that in drag_suite_run.

Priority:

• Critical Bugfix: Reason
• High: Fix model instability issue
• Normal

Git Tracking

Sub component Pull Requests:

• UFSATM: Modified 'dtfac' OGWD tendency limiter in drag_suite_psl to match that in drag_suite_run NOAA-EMC/ufsatm#1058
  • ccpp-physics: Modified 'dtfac' OGWD tendency limiter in drag_suite_psl to match that in drag_suite_run ccpp-physics#349

UFSWM Blocking Dependencies:

• Blocked by #
• None

Documentation:

• Documentation update required.
  • Relevant updates are included with this PR.
  • A WM issue has been opened to track the need for a documentation update; a person responsible for submitting the update has been assigned to the issue (link issue).
• Documentation update NOT required.
  • Explanation:

---

Changes

Regression Test Changes (Please commit test_changes.list):

• PR Adds New Tests/Baselines.
• PR Updates/Changes Baselines.
• No Baseline Changes.

Input data Changes:

• None.
• PR adds input data.
• PR changes existing input data.

Library Changes/Upgrades:

• Required
  • Library names w/versions:
  • Git Stack Issue (JCSDA/spack-stack#)
• No Updates

---

Testing Log:

• RDHPCS
  • Hera
  • Orion
  • Hercules
  • GaeaC6
  • Derecho
  • Ursa
• WCOSS2
  • Dogwood/Cactus
  • Acorn
• CI
• opnReqTest (complete task if unnecessary)

[gspetro-NOAA]

@XiaqiongZhou-NOAA In order to schedule this PR for the commit queue, we'll need you to run the full RT suite (preferably on Ursa, although Hercules or another platform would do) and push the logs and the test_changes.list file showing which baselines will change. The Commit Message section of the template also needs to be filled out with a commit message for each subcomponent.

[XiaqiongZhou-NOAA]

test_changes.list is added. New baseline on URSA: /scratch4/NCEPDEV/stmp/Xiaqiong.Zhou/RT_BASELINE/Xiaqiong.Zhou/FV3_RT/REGRESSION_TEST
Just wondering which rt.sh flags should be used to generate log file to be committed for full regression tests.

[dpsarmie]

The logs to add to the PR should be in the ufswm directory that you used to run the RTs. ex. ./ufs-weather-model/tests/logs/RegressionTests_ursa.log, substitute the log for the machine used in testing.

There shouldn't be any special flags needed in rt.sh.

[XiaqiongZhou-NOAA]

The logs to add to the PR should be in the ufswm directory that you used to run the RTs. ex. ./ufs-weather-model/tests/logs/RegressionTests_ursa.log, substitute the log for the machine used in testing.

There shouldn't be any special flags needed in rt.sh.

Daniel: Doe you mean the log files that indicates fails for all RTs with baseline changed?

[dpsarmie]

Daniel: Doe you mean the log files that indicates fails for all RTs with baseline changed?

Yes, that log file with the failures listed.

[gspetro-NOAA]

@XiaqiongZhou-NOAA Could you please sync w/develop? We'd like to process this PR next.

[gspetro-NOAA]

@XiaqiongZhou-NOAA Thanks for updating UFSATM. It looks like MOM6 is out-of-date though. It should be pointing to b4d9a23.

[BrianCurtis-NOAA]

Prod switch, WCOSS2 confirmed all tests pass.

[gspetro-NOAA]

@BrianCurtis-NOAA We're waiting for Ursa to come back online 😕

[gspetro-NOAA]

The UFSATM PR has been merged. Please revert .gitmodules and update UFSATM to hash c20b46c.

[XiaqiongZhou-NOAA]

The UFSATM PR has been merged. Please revert .gitmodules and update UFSATM to hash c20b46c.

Done.