Skip to content

Start to remove stale RTs // Add GUST_CONST as a variable #3056 // PR-Arbetter-JenkinsfileORT #3066 #3065

Merged
gspetro-NOAA merged 15 commits intoufs-community:developfrom
dpsarmie:feature/remove-stale-RTs
Feb 2, 2026
Merged

Start to remove stale RTs // Add GUST_CONST as a variable #3056 // PR-Arbetter-JenkinsfileORT #3066 #3065
gspetro-NOAA merged 15 commits intoufs-community:developfrom
dpsarmie:feature/remove-stale-RTs

Conversation

@dpsarmie
Copy link
Copy Markdown
Collaborator

@dpsarmie dpsarmie commented Jan 26, 2026

Commit Queue Requirements:

  • This PR addresses a relevant WM issue (if not, create an issue).
  • All subcomponent pull requests (if any) have been reviewed by their code managers.
  • Run the full Intel+GNU RT suite (compared to current baselines), preferably on Ursa (Derecho or Hercules are acceptable alternatives). Exceptions: documentation-only PRs, CI-only PRs, etc.
    • Commit log file w/full results from RT suite run (if applicable).
    • Verify that test_changes.list indicates which tests, if any, are changed by this PR. Commit test_changes.list, even if it is empty.
  • Fill out all sections of this template.

Description:

UFSWM PR #3065

This PR starts to remove some of the stale RTs that are in the regression test suite. There was a discussion in an old PR (#2173 (comment)) that talked about what tests could be removed. Some were removed but others were not. This will complete the process for the tests that were not removed at the time (mostly flake).

UFSWM PR #3056

The non-default value of GUST_CONST in MOM6 is being used in SFS. This PR creates a way to easier edit this value in ufs-weather-model and GW. This is only changes in scripting.

UFSWM PR #3066

Updates Jenkinsfile.ort and OpnReqTests to run on ursa & other platforms

Commit Message:

* UFSWM - Remove flake and other stale regression tests
* UFSWM - Use non-default value of MOM6 GUST_CONST variable in SFS
* UFSWM - update Jenkinsfile.ort and OpnReqTests to run on ursa & other platforms

Priority:

  • Critical Bugfix: Reason
  • High: Reason
  • Normal

Git Tracking

UFSWM:

Sub component Pull Requests:

  • None

UFSWM Blocking Dependencies:

  • Blocked by #
  • None

Documentation:

  • Documentation update required.
    • Relevant updates are included with this PR.
    • A WM issue has been opened to track the need for a documentation update; a person responsible for submitting the update has been assigned to the issue (link issue).
  • Documentation update NOT required.
    • Explanation: No fundamental changes were made

Changes

Regression Test Changes (Please commit test_changes.list):

  • PR Adds New Tests/Baselines.
  • PR Updates/Changes Baselines.
  • No Baseline Changes.

Input data Changes:

  • None.
  • PR adds input data.
  • PR changes existing input data.

Library Changes/Upgrades:

  • Required
    • Library names w/versions:
    • Git Stack Issue (JCSDA/spack-stack#)
  • No Updates

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • GaeaC6
    • Derecho
    • Ursa
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
  • opnReqTest (complete task if unnecessary)

@github-project-automation github-project-automation bot moved this to Evaluating in PRs to Process Jan 26, 2026
@gspetro-NOAA gspetro-NOAA added the No Baseline Change No Baseline Change label Jan 28, 2026
@gspetro-NOAA gspetro-NOAA moved this from Evaluating to Review in PRs to Process Jan 28, 2026
@gspetro-NOAA
Copy link
Copy Markdown
Collaborator

@dpsarmie Is there any more work to do for this one, or could we combine it with, e.g., 3056?

@dpsarmie
Copy link
Copy Markdown
Collaborator Author

@dpsarmie Is there any more work to do for this one, or could we combine it with, e.g., 3056?

I'm ok with combining it. There's more RT reworks that will be occurring but the timing on those might vary as we try to get input from groups and projects.

@FernandoAndrade-NOAA FernandoAndrade-NOAA moved this from Review to Schedule in PRs to Process Jan 28, 2026
@FernandoAndrade-NOAA
Copy link
Copy Markdown
Collaborator

@dpsarmie Please go ahead and bring in updates from #3056

@dpsarmie
Copy link
Copy Markdown
Collaborator Author

@dpsarmie Please go ahead and bring in updates from #3056

Done. I'll start to edit the PR description.

@dpsarmie dpsarmie changed the title Start to remove stale RTs Start to remove stale RTs // Add GUST_CONST as a variable #3056 Jan 28, 2026
@FernandoAndrade-NOAA
Copy link
Copy Markdown
Collaborator

Please bring in #3066 as well. Once that's in and this PR is resynced, we can get started on RTs.

@FernandoAndrade-NOAA FernandoAndrade-NOAA changed the title Start to remove stale RTs // Add GUST_CONST as a variable #3056 Start to remove stale RTs // Add GUST_CONST as a variable #3056 // PR-Arbetter-JenkinsfileORT #3066 Jan 28, 2026
@FernandoAndrade-NOAA FernandoAndrade-NOAA added Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked. In Testing The PR that is currently in testing stages ursa-ORT and removed ursa-ORT In Testing The PR that is currently in testing stages labels Jan 29, 2026
@FernandoAndrade-NOAA
Copy link
Copy Markdown
Collaborator

Testing on short hold, there is one more update expected for #3056.

@FernandoAndrade-NOAA
Copy link
Copy Markdown
Collaborator

I believe we should be good to go, please resync with 3056 one more time. Apologies for the delay.

@dpsarmie
Copy link
Copy Markdown
Collaborator Author

I believe we should be good to go, please resync with 3056 one more time. Apologies for the delay.

Ok, changes have been merged.

@FernandoAndrade-NOAA
Copy link
Copy Markdown
Collaborator

I believe we should be good to go, please resync with 3056 one more time. Apologies for the delay.

Ok, changes have been merged.

Could you double check the sync? I'm seeing changes in the MOM_input_hafs within 3056 not present in this PR

@dpsarmie
Copy link
Copy Markdown
Collaborator Author

Could you double check the sync? I'm seeing changes in the MOM_input_hafs within 3056 not present in this PR

Resync'd. Looks like it's there now.

@FernandoAndrade-NOAA FernandoAndrade-NOAA added the In Testing The PR that is currently in testing stages label Jan 30, 2026
@FernandoAndrade-NOAA FernandoAndrade-NOAA added jenkins-ort run ORT testing ursa-ORT and removed jenkins-ort run ORT testing labels Jan 30, 2026
@gspetro-NOAA gspetro-NOAA removed the In Testing The PR that is currently in testing stages label Feb 2, 2026
@gspetro-NOAA gspetro-NOAA merged commit 06afcd6 into ufs-community:develop Feb 2, 2026
13 checks passed
@gspetro-NOAA gspetro-NOAA mentioned this pull request Feb 2, 2026
25 tasks
dpsarmie added a commit to dpsarmie/ufs-weather-model that referenced this pull request Feb 23, 2026
dpsarmie added a commit that referenced this pull request Mar 2, 2026
…#3105)

* Add separate zstd options for restarts

* Fix default_vars.sh

* Add WRITE_GEOM from #3065

* Add WW3 GFSv17 production branch

* Update UFSATM hash :: zstd_rst option

---------

Co-authored-by: Daniel Sarmiento <daniel.sarmiento@clogin06.cactus.wcoss2.ncep.noaa.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

No Baseline Change No Baseline Change Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Remove stale RTs which fail with current GFSv17 namelist Clean up some old regression tests MOM6 GUST_CONST as a variable

6 participants