Fix premature finalizes and retrieval of is_moving info in ATM cap (#3093) // Aquaplanet test case (#3013)

[DeniseWorthen]

Commit Queue Requirements:

• This PR addresses a relevant WM issue (if not, create an issue).
• All subcomponent pull requests (if any) have been reviewed by their code managers.
• Run the full Intel+GNU RT suite (compared to current baselines), preferably on Ursa (Derecho or Hercules are acceptable alternatives). Exceptions: documentation-only PRs, CI-only PRs, etc.
  • Commit log file w/full results from RT suite run (if applicable).
  • Verify that test_changes.list indicates which tests, if any, are changed by this PR. Commit test_changes.list, even if it is empty.
• Fill out all sections of this template.

---

Description:

#3093

Adds two small changes in UFSATM cap which resolve two edge use cases.

#3013

Within HSD project, new test case is developed called "Aquaplanet". We added that test to the ufs-weather-model/tests-dev/ directory.

Commit Message:

* UFSWM - added aquaplanet test under ufs-weather-model/tests-dev/ directory
  * UFSATM - add a barrier in the UFS ATM cap and reorder the retrieval of the is_moving info when intitializing the WCG

Priority:

• Normal

Git Tracking

UFSWM:

• Fixes model execution can fail when components (including wgc) stop at different times #3068
  • Fixes ESMF run time error: Not found  - [json.exception.out_of_range.403] key 'is_moving' not found NOAA-EMC/ufsatm#1023
• Closes Add aquaplanet idealized configuration to UFS HSD framework #2911

Sub component Pull Requests:

• UFSATM: Add VM barrier and fix is_moving logic NOAA-EMC/ufsatm#1067

UFSWM Blocking Dependencies:

• None

Documentation:

• Documentation update NOT required for Fix premature finalizes and retrieval of is_moving info in ATM cap (#3093) // Aquaplanet test case (#3013) #3093.
  • Explanation: Edge use cases only
• Documentation required for Aquaplanet test case #3013 content; will be added via HSD Aquaplanet Documentation #3096 .

---

Changes

Regression Test Changes (Please commit test_changes.list):

• No Baseline Changes.

Input data Changes:

• None.

Library Changes/Upgrades:

• No Updates

---

Testing Log:

• RDHPCS
  • Orion
  • Hercules
  • GaeaC6
  • Derecho
  • Ursa
• WCOSS2
  • Dogwood/Cactus
  • Acorn
• CI
• opnReqTest (complete task if unnecessary)

[gspetro-NOAA]

@DeniseWorthen The UFSATM PR has been merged. Please revert .gitmodules and update the UFSATM hash to 01bcf1d.

[DeniseWorthen]

Why are we approving PRs where the checks are failing?

[FernandoAndrade-NOAA]

repo_check is failing due to AQM merging 124 and 125 without an accompanying UFS WM PR. The super linter failures are temporary and will need follow up changes after needing to update the version due to a security issue noted in #3072

[gspetro-NOAA]

Why are we approving PRs where the checks are failing?

The Super Linter is something that I believe @BrianCurtis-NOAA is looking into a fix for. In PR #3072 he commented that "a security risk in older superlinter forced our hand a bit getting a newer version used in the CI. It can fail for now, but we'll want to work on a PR that adjusts things to pass again."
The Repo_check is failing because AQM just updated its develop branch outside of the PR process, so it's temporarily broken that CI.
Therefore, these two failures do not indicate a problem with the PR itself. I'll file issues though so that they are tracked more publicly.

[jkbk2004]

we should catch up AQM hash in next PR.