Skip to content

Remove some goto statements in FV3 and update TAdyn warning range#3169

Open
dpsarmie wants to merge 3 commits intoufs-community:developfrom
dpsarmie:fix/fv3_removeGOTO_relaxTAdynWarning
Open

Remove some goto statements in FV3 and update TAdyn warning range#3169
dpsarmie wants to merge 3 commits intoufs-community:developfrom
dpsarmie:fix/fv3_removeGOTO_relaxTAdynWarning

Conversation

@dpsarmie
Copy link
Copy Markdown
Collaborator

Commit Queue Requirements:

  • This PR addresses a relevant WM issue (if not, create an issue).
  • All subcomponent pull requests (if any) have been reviewed by their code managers.
  • Run the full Intel+GNU RT suite (compared to current baselines), preferably on Ursa (Derecho or Hercules are acceptable alternatives). Exceptions: documentation-only PRs, CI-only PRs, etc.
    • Commit log file w/full results from RT suite run (if applicable).
    • Verify that test_changes.list indicates which tests, if any, are changed by this PR. Commit test_changes.list, even if it is empty.
  • Fill out all sections of this template.

Description:

This PR will bring in changes made to the FV3 repository that removed some goto statements (EE2 requirements / code modernization) and fixed the range for the warning trigger on TAdyn.
Removing / reducing the number of goto and do continue in the code was an ask by NCO.

Commit Message:

* UFSWM - Remove some goto statements in FV3 and relax warning for TAdyn
  * UFSATM - Update atmos-cubed hash
    * atmos_cubed_sphere - Remove some goto statements in FV3 and relax warning for TAdyn

Priority:

  • Critical Bugfix: Reason
  • High: Reason
  • Normal

Git Tracking

UFSWM:

Sub component Pull Requests:

UFSWM Blocking Dependencies:

  • None

Documentation:

  • Documentation update NOT required.

Changes

Regression Test Changes (Please commit test_changes.list):

  • No Baseline Changes.

Input data Changes:

  • None.

Library Changes/Upgrades:

Testing Log:

  • RDHPCS
    • Orion
    • Hercules
    • GaeaC6
    • Derecho
    • Ursa
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
  • opnReqTest (complete task if unnecessary)

@dpsarmie dpsarmie self-assigned this Mar 30, 2026
@github-project-automation github-project-automation bot moved this to Evaluating in PRs to Process Mar 30, 2026
@gspetro-NOAA gspetro-NOAA added No Baseline Change No Baseline Change UFSATM There are changes to the UFSATM repository. A3S There are changes to the atmos_cubed_sphere component repository. labels Mar 30, 2026
@gspetro-NOAA gspetro-NOAA moved this from Evaluating to Waiting for Reviews (subcomponent) in PRs to Process Mar 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A3S There are changes to the atmos_cubed_sphere component repository. No Baseline Change No Baseline Change UFSATM There are changes to the UFSATM repository.

Projects

Status: Waiting for Reviews (subcomponent)

Development

Successfully merging this pull request may close these issues.

Reduce number of goto statements in FV3 submodule

2 participants