Use tcp fin instead of rst when disconnecting (issue 58) #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If receive with flag fin, ack it and close connection. Call tcp_disconnect() in state machine. Add tcp_disconnect: if established -> sendFin, if syn sent -> sendReset. Hopefully fixes issue 58 where charger do not like being sent a RST. Not tested.
Contributor
Author
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If receive with flag fin, ack it and close connection. Call tcp_disconnect() in state machine.
Add tcp_disconnect: if established -> sendFin, if syn sent -> sendReset. Hopefully fixes issue 58 where charger do not like being sent a RST. Not tested here, allthou I run similar code in ccs32clara-chademo with success.