Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding onBadInput callback #38

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Adding onBadInput callback #38

wants to merge 3 commits into from

Conversation

alexf2
Copy link

@alexf2 alexf2 commented Apr 18, 2018

There may be a need to know, when user makes a bad input. For example, if you want to highlight the input for a short time.

@uhlryk
Copy link
Owner

uhlryk commented Apr 24, 2018

Thank you for this improvement. It looks great.
I would like to merge it. But I think that it would be great if you would also add few words in README.md about this new functionality.

…strap 4, adding run-example Npm script, fixing some wording in ReadMe
@alexf2
Copy link
Author

alexf2 commented Apr 30, 2018

  1. Added some Readme doc for onBadInput.
  2. Fixed some wording in the doc.
  3. Added an example for onBadInput, showing red highlighting (the most bottom input).
  4. Added "run-example" Npm script along with hot-reloading.
  5. Made some corrections in package.json Npm scripts to make them working on Windows.
  6. Ported the example to Bootstrap 4.
  7. Made some marginal refactorings.

P.S. I suggest testing Npm scripts on Linux or Mac. I didn't as I don't have them at hand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants