Skip to content

fix: allow non-standard web stream #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: allow non-standard web stream #30

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 30 additions & 8 deletions src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,18 +30,40 @@ const isDuplexNodeStream = obj =>
typeof obj.on === 'function' &&
typeof obj.write === 'function';

const isNodeStream = obj => {
return (
obj &&
(obj._readableState ||
obj._writableState ||
(typeof obj.write === 'function' && typeof obj.on === 'function') ||
(typeof obj.pipe === 'function' && typeof obj.on === 'function'))
);
};

const isReadableWebStream = obj =>
obj && globalThis.ReadableStream && obj instanceof globalThis.ReadableStream;
!!(
obj &&
!isNodeStream(obj) &&
typeof obj.pipeThrough === 'function' &&
typeof obj.getReader === 'function' &&
typeof obj.cancel === 'function'
);

const isWritableWebStream = obj =>
obj && globalThis.WritableStream && obj instanceof globalThis.WritableStream;
!!(
obj &&
!isNodeStream(obj) &&
typeof obj.getWriter === 'function' &&
typeof obj.abort === 'function'
);

const isDuplexWebStream = obj =>
obj &&
globalThis.ReadableStream &&
obj.readable instanceof globalThis.ReadableStream &&
globalThis.WritableStream &&
obj.writable instanceof globalThis.WritableStream;
!!(
obj &&
!isNodeStream(obj) &&
typeof obj.readable === 'object' &&
typeof obj.writable === 'object'
);

const groupFunctions = (output, fn, index, fns) => {
if (
Expand Down Expand Up @@ -239,7 +261,7 @@ module.exports.normalizeMany = defs.normalizeMany;
module.exports.combineMany = defs.combineMany;
module.exports.combineManyMut = defs.combineManyMut;

module.exports.chain = chain; // for compatibility with 2.x
module.exports.chain = chain; // for compatibility with 2.x
module.exports.chainUnchecked = chain; // for TypeScript to bypass type checks
module.exports.gen = gen;
module.exports.asStream = asStream;
Expand Down